On 28/10/15 17:44, Junio C Hamano wrote:
Luke Diamand writes:
On 9 September 2015 at 22:52, Junio C Hamano wrote:
Luke Diamand writes:
...
def currentGitBranch():
return read_pipe("git name-rev HEAD").split(" ")[1].strip()
Yuck. I know it is not entirely the fault of this pa
Luke Diamand writes:
> On 9 September 2015 at 22:52, Junio C Hamano wrote:
>> Luke Diamand writes:
>> ...
>> def currentGitBranch():
>> return read_pipe("git name-rev HEAD").split(" ")[1].strip()
>>
>> Yuck. I know it is not entirely the fault of this patch, but
>> shouldn't it be
Luke Diamand writes:
> On 9 September 2015 at 22:52, Junio C Hamano wrote:
>> Luke Diamand writes:
>>
>>> def run(self, args):
>>> if len(args) == 0:
>>> self.master = currentGitBranch()
>>> -if len(self.master) == 0 or not
>>> gitBranchExists("refs/heads
On 9 September 2015 at 22:52, Junio C Hamano wrote:
> Luke Diamand writes:
>
>> def run(self, args):
>> if len(args) == 0:
>> self.master = currentGitBranch()
>> -if len(self.master) == 0 or not gitBranchExists("refs/heads/%s"
>> % self.master):
>> -
Luke Diamand writes:
> def run(self, args):
> if len(args) == 0:
> self.master = currentGitBranch()
> -if len(self.master) == 0 or not gitBranchExists("refs/heads/%s"
> % self.master):
> -die("Detecting current git branch failed!")
> +
When submitting, git-p4 finds the current branch in
order to know if it is allowed to submit (configuration
"git-p4.allowSubmit").
On a detached head, detecting the branch would fail, and
git-p4 would report a cryptic error.
This change teaches git-p4 to recognise a detached head and
submit succe
6 matches
Mail list logo
