Re: [PATCH v9 5/9] rebase: refactor can_fast_forward into goto tower

2019-08-26 Thread Denton Liu
On Sun, Aug 25, 2019 at 06:47:02PM +0530, Pratyush Yadav wrote: > On 25/08/19 05:12AM, Denton Liu wrote: > > Before, can_fast_forward was written with an if-else statement. However, > > in the future, we may be adding more termination cases which would lead > > to deeply nested if statements. > >

Re: [PATCH v9 5/9] rebase: refactor can_fast_forward into goto tower

2019-08-25 Thread Pratyush Yadav
On 25/08/19 05:12AM, Denton Liu wrote: > Before, can_fast_forward was written with an if-else statement. However, > in the future, we may be adding more termination cases which would lead > to deeply nested if statements. > > Refactor to use a goto tower so that future cases can be easily > insert

[PATCH v9 5/9] rebase: refactor can_fast_forward into goto tower

2019-08-25 Thread Denton Liu
Before, can_fast_forward was written with an if-else statement. However, in the future, we may be adding more termination cases which would lead to deeply nested if statements. Refactor to use a goto tower so that future cases can be easily inserted. Signed-off-by: Denton Liu --- builtin/rebase