Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-06 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio & Lars, > > On Wed, 5 Oct 2016, Junio C Hamano wrote: > >> Lars Schneider writes: >> >> > OK. Something like the patch below would work nicely. >> >> Yeah, something along that line; it would eliminate the need to >> worry about a field named "stdin" ;-)

Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-06 Thread Johannes Schindelin
Hi Junio & Lars, On Wed, 5 Oct 2016, Junio C Hamano wrote: > Lars Schneider writes: > > > OK. Something like the patch below would work nicely. > > Yeah, something along that line; it would eliminate the need to > worry about a field named "stdin" ;-) Not only a need to worry. Git for Windows

Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-06 Thread Lars Schneider
> On 06 Oct 2016, at 11:32, Johannes Schindelin > wrote: > > Hi Junio & Lars, > > On Wed, 5 Oct 2016, Junio C Hamano wrote: > >> Lars Schneider writes: >> >>> OK. Something like the patch below would work nicely. >> >> Yeah, something along that line; it would eliminate the need to >> worr

Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-05 Thread Junio C Hamano
Lars Schneider writes: > OK. Something like the patch below would work nicely. Yeah, something along that line; it would eliminate the need to worry about a field named "stdin" ;-) But ... > while (children_to_clean) { > struct child_to_clean *p = children_to_clean; >

Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-05 Thread Lars Schneider
> On 04 Oct 2016, at 21:30, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> The flag 'clean_on_exit' kills child processes spawned by Git on exit. >> A hard kill like this might not be desired in all cases. >> >> Add 'wait_on_exit' which closes the

Re: [PATCH v9 04/14] run-command: add wait_on_exit

2016-10-04 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > > The flag 'clean_on_exit' kills child processes spawned by Git on exit. > A hard kill like this might not be desired in all cases. > > Add 'wait_on_exit' which closes the child's stdin on Git exit and waits > until the child process has t

[PATCH v9 04/14] run-command: add wait_on_exit

2016-10-04 Thread larsxschneider
From: Lars Schneider The flag 'clean_on_exit' kills child processes spawned by Git on exit. A hard kill like this might not be desired in all cases. Add 'wait_on_exit' which closes the child's stdin on Git exit and waits until the child process has terminated. The flag is used in a subsequent p