Re: [PATCH v8 32/41] environment: add set_index_file()

Duy Nguyen writes: > On Fri, Jul 29, 2016 at 8:23 PM, Christian Couder > >> Do you mean that it might be a source of micro-projects for the next >> GSoC or Outreachy? ;-) > > No that's what I meant by boring. This is not something to interest > GSoC candidates, and while it looks simple, sometim

Re: [PATCH v8 32/41] environment: add set_index_file()

On Fri, Jul 29, 2016 at 8:23 PM, Christian Couder wrote: > On Fri, Jul 29, 2016 at 5:34 PM, Duy Nguyen wrote: >> >> Yeah. If the libification movement is going strong, we can start >> converting and at some point should be able to define >> NO_THE_INDEX_COMPATIBILITY_MACROS globally (and avoid th

Re: [PATCH v8 32/41] environment: add set_index_file()

On Fri, Jul 29, 2016 at 5:34 PM, Duy Nguyen wrote: > > Yeah. If the libification movement is going strong, we can start > converting and at some point should be able to define > NO_THE_INDEX_COMPATIBILITY_MACROS globally (and avoid the_index along > the way) > > Without that, there is a risk. I lo

Re: [PATCH v8 32/41] environment: add set_index_file()

On Fri, Jul 29, 2016 at 4:21 PM, Christian Couder wrote: >> I agree we should avoid this. There's a bunch of cache_name_pos() (and >> even read_cache()) in the libified apply.c, those will need to be >> converted to take struct index_state* directly (read_index_from or >> index_name_pos). > > The

Re: [PATCH v8 32/41] environment: add set_index_file()

On Wed, Jul 27, 2016 at 5:14 PM, Duy Nguyen wrote: > On Tue, Jul 26, 2016 at 9:28 PM, Junio C Hamano wrote: >> Christian Couder writes: >> >>> Introduce set_index_file() to be able to temporarily change the index file. >>> >>> It should be used like this: >>> >>> /* Save current index file *

Re: [PATCH v8 32/41] environment: add set_index_file()

On Tue, Jul 26, 2016 at 9:28 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Introduce set_index_file() to be able to temporarily change the index file. >> >> It should be used like this: >> >> /* Save current index file */ >> old_index_file = get_index_file(); >> set_index_

Re: [PATCH v8 32/41] environment: add set_index_file()

Christian Couder writes: > Introduce set_index_file() to be able to temporarily change the index file. > > It should be used like this: > > /* Save current index file */ > old_index_file = get_index_file(); > set_index_file((char *)tmp_index_file); > > /* Do stuff that will use tm

[PATCH v8 32/41] environment: add set_index_file()

Introduce set_index_file() to be able to temporarily change the index file. It should be used like this: /* Save current index file */ old_index_file = get_index_file(); set_index_file((char *)tmp_index_file); /* Do stuff that will use tmp_index_file as the index file */ ...