Re: [PATCH v8 10/19] index-helper: use watchman to avoid refreshing index with lstat()

2016-05-05 Thread Junio C Hamano
David Turner writes: > +extern void write_watchman_ext(struct strbuf *sb, struct index_state* > istate); Asterisk sticks to the variable, not to the type. > + if (c == sb.buf) { > + strbuf_setlen(&sb, 0); > + } Unnecessary braces {}. -- To unsubscribe from this list: send

[PATCH v8 10/19] index-helper: use watchman to avoid refreshing index with lstat()

2016-05-05 Thread David Turner
From: Nguyễn Thái Ngọc Duy Watchman is hidden behind index-helper. Before git tries to read the index from shm, it notifies index-helper through the socket and waits for index-helper to prepare a file for sharing memory (with MAP_SHARED). index-helper then contacts watchman, updates 'WAMA' extens