Re: [PATCH v8 00/41] libify apply and use lib in am, part 2

2016-07-30 Thread Christian Couder
On Wed, Jul 27, 2016 at 6:24 PM, Junio C Hamano wrote: > Christian Couder writes: > >>> The early part up to and including "apply: make some parsing >>> functions static again" looked good and we could treat them as a >>> continuation of the earlier cc/apply-introduce-state topic, which >>> has b

Re: [PATCH v8 00/41] libify apply and use lib in am, part 2

2016-07-27 Thread Junio C Hamano
Christian Couder writes: >> I finally found time to get back to finish reviewing this. > > Great, thanks! No, thank _you_ for working on this. >> The early part up to and including "apply: make some parsing >> functions static again" looked good and we could treat them as a >> continuation of t

Re: [PATCH v8 00/41] libify apply and use lib in am, part 2

2016-07-26 Thread Christian Couder
On Tue, Jul 26, 2016 at 11:18 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Sorry if this patch series is still long. I can split it into two or >> more series if it is prefered. >> ... >> Christian Couder (41): >> apply: make some names more specific >> apply: move 'struct apply_

Re: [PATCH v8 00/41] libify apply and use lib in am, part 2

2016-07-26 Thread Junio C Hamano
Christian Couder writes: > Sorry if this patch series is still long. I can split it into two or > more series if it is prefered. > ... > Christian Couder (41): > apply: make some names more specific > apply: move 'struct apply_state' to apply.h > builtin/apply: make apply_patch() return -1

Re: [PATCH v8 00/41] libify apply and use lib in am, part 2

2016-06-27 Thread Christian Couder
On Mon, Jun 27, 2016 at 8:23 PM, Christian Couder wrote: > > I will send a diff between this version and the previous one, as a > reply to this email. Here is the diff: diff --git a/apply.c b/apply.c index 98a..2ac22d3 100644 --- a/apply.c +++ b/apply.c @@ -1516,8 +1516,8 @@ static int parse

[PATCH v8 00/41] libify apply and use lib in am, part 2

2016-06-27 Thread Christian Couder
Goal This is a patch series about libifying `git apply` functionality, and using this libified functionality in `git am`, so that no 'git apply' process is spawn anymore. This makes `git am` significantly faster, so `git rebase`, when it uses the am backend, is also significantly faster. Pre