Re: [PATCH v8 0/3]

2019-03-13 Thread Nickolai Belakovski
> > Patch 1 looks good to me. Given that we're on v8 and most of the other > comments are for patches 2 and 3, I think we might consider graduating > it separately if the other two are not ready soon. It's independently > useful, IMHO. Patch 2 was my main motivation, so it would be nice to get it

Re: [PATCH v8 0/3]

2019-02-21 Thread Jeff King
On Tue, Feb 19, 2019 at 05:31:20PM +0900, nbelakov...@gmail.com wrote: > From: Nickolai Belakovski > > I've made the various cosmetic changes that were suggested, as well as adding > tests for 3/3 > > I don't have a particularly strong opinion on the subject of keeping the atom > as "worktree

[PATCH v8 0/3]

2019-02-19 Thread nbelakovski
From: Nickolai Belakovski I've made the various cosmetic changes that were suggested, as well as adding tests for 3/3 I don't have a particularly strong opinion on the subject of keeping the atom as "worktreepath" or changing it to "worktree:path". We did feel earlier in this thread that if w

[PATCH v8 0/3] http-backend: respect CONTENT_LENGTH as specified by rfc3875

2018-06-10 Thread Max Kirillov
Did the fixes proposed for v7 Max Kirillov (3): http-backend: cleanup writing to child process http-backend: respect CONTENT_LENGTH as specified by rfc3875 http-backend: respect CONTENT_LENGTH for receive-pack config.c | 2 +- config.h

[PATCH v8 0/3] read-cache: speed up add_index_entry

2017-04-10 Thread git
From: Jeff Hostetler Version 8 addresses the following: () Refactors strcmp_offset() test helper to just compare the values and return results to stdout. () Updates t0065 to have the actual test logic. () Splits the synthetic test repo generation out of the perf test into a stand-

[PATCH v8 0/3] bisect--helper: check-term-format() & write_terms()

2016-05-24 Thread Pranit Bauva
Here is the link to v7[1]. This has a few modifications. Changes wrt v7 as suggested by Eric are: * Include the name of the file in the error message which couldn't be opened. * Use error_errno() with which we can make the error message more valuable. Pranit Bauva (3): bisect--helper: use O

[PATCH v8 0/3] Add support for sending additional HTTP headers (part 2)

2016-05-10 Thread Johannes Schindelin
My use case is an army of build agents that need only limited and selective access to otherwise private repositories. The first part already made it into `master`, this is the remainder. This iteration is based on 'jk/submodule-c-credential' and therefore converted the original config-sanitizing

[PATCH v8 0/3] git config cache & special querying api utilizing the cache

2014-07-10 Thread Tanay Abhra
Hi, [PATCH V8]: Moved the contents of config-set.c to config.c for future convenience. Reverted test 'find value with misspelled key' to the one in v5. See [10] for the discussion. [PATCH V7]: Style nits and a broken && chain corrected in `t/t1308-config-set.sh`. See [9] for th

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-21 Thread David Aguilar
On Tue, May 21, 2013 at 12:19 PM, Torsten Bögershausen wrote: > On 2013-05-21 00.52, Junio C Hamano wrote: >> Thanks, will replace da/darwin with this round. > (May be late response, not sure if this is the right email thread. > I eventually managed to compile under 10.6, what we have on pu) > > O

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-21 Thread Jonathan Nieder
Torsten Bögershausen wrote: > One minor nit, or 2: > imap-send.c: In function ‘cram’: > imap-send.c:913: warning: statement with no effect > > This fixes it: > > diff --git a/imap-send.c b/imap-send.c > index 8ea180f..11577c9 100644 > --- a/imap-send.c > +++ b/imap-send.c > @@ -35,7 +35,7 @@ typed

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-21 Thread Torsten Bögershausen
On 2013-05-21 00.52, Junio C Hamano wrote: > Thanks, will replace da/darwin with this round. (May be late response, not sure if this is the right email thread. I eventually managed to compile under 10.6, what we have on pu) One minor nit, or 2: imap-send.c: In function ‘cram’: imap-send.c:913: war

Re: [PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-20 Thread Junio C Hamano
Thanks, will replace da/darwin with this round. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v8 0/3] Begin replacing OpenSSL with CommonCrypto

2013-05-19 Thread Eric Sunshine
This is a re-roll of David Aguilar's patch series [1] which eliminates some of the OpenSSL deprecation warnings on Mac OS X. Changes since v7: - Avoid double-negation (#ifndef NO_APPLE_COMMON_CRYPTO) - Don't break imap-send.c for platforms other than Apple [1]: http://thread.gmane.org/gmane.comp.

Re: [PATCH v8 0/3] submodule update: add --remote for submodule's upstream changes

2012-12-21 Thread Heiko Voigt
Hi, On Wed, Dec 19, 2012 at 11:03:30AM -0500, wk...@tremily.us wrote: > From: "W. Trevor King" > > Comments on v7 seem to have petered out, so here's v8. Changes since > v7: > > * Series based on gitster/master instead of v1.8.0. > * In Documentation/config.txt, restored trailing line of > s

[PATCH v8 0/3] submodule update: add --remote for submodule's upstream changes

2012-12-19 Thread wking
From: "W. Trevor King" Comments on v7 seem to have petered out, so here's v8. Changes since v7: * Series based on gitster/master instead of v1.8.0. * In Documentation/config.txt, restored trailing line of submodule..update documentation, which I had accidentally removed in v7. * In Document