Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-06 Thread Brandon Williams
On 12/06, Jeff King wrote: > On Mon, Dec 05, 2016 at 12:04:52PM -0800, Junio C Hamano wrote: > > > > I'm sending out another reroll of this series so that in Jeff's he can > > > just call 'get_curl_allowed_protocols(-1)' for the non-redirection curl > > > option, which should make this test stop b

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-06 Thread Jeff King
On Tue, Dec 06, 2016 at 09:53:53AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I don't know if that makes things any easier. I feel funny saying "no, > > no, mine preempts yours because it is more maint-worthy", but I think > > that order does make sense. > > > > I think it would be O

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-06 Thread Junio C Hamano
Jeff King writes: > I don't know if that makes things any easier. I feel funny saying "no, > no, mine preempts yours because it is more maint-worthy", but I think > that order does make sense. > > I think it would be OK to put Brandon's on maint, too, though. It is a > refactor of an existing sec

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-06 Thread Jeff King
On Mon, Dec 05, 2016 at 12:04:52PM -0800, Junio C Hamano wrote: > > I'm sending out another reroll of this series so that in Jeff's he can > > just call 'get_curl_allowed_protocols(-1)' for the non-redirection curl > > option, which should make this test stop barfing. > > I was hoping to eventual

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-05 Thread Brandon Williams
On 12/05, Junio C Hamano wrote: > Brandon Williams writes: > > > I just took Jeff's series and applied it on top of mine (and fixed the > > small problem causing t5812 to fail) and then rebased it to v2.9.0. > > There were a few issues that needed to be resolved but nothing too > > hairy. So it

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-05 Thread Junio C Hamano
Brandon Williams writes: > I just took Jeff's series and applied it on top of mine (and fixed the > small problem causing t5812 to fail) and then rebased it to v2.9.0. > There were a few issues that needed to be resolved but nothing too > hairy. So it would definitely be doable to backport it to

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-05 Thread Brandon Williams
On 12/05, Junio C Hamano wrote: > Brandon Williams writes: > > > On 12/01, Junio C Hamano wrote: > >> Brandon Williams writes: > >> > >> > I started taking a look at your http redirect series (I really should > >> > have taking a look at it sooner) and I see exactly what you're talking > >> > a

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-05 Thread Junio C Hamano
Brandon Williams writes: > On 12/01, Junio C Hamano wrote: >> Brandon Williams writes: >> >> > I started taking a look at your http redirect series (I really should >> > have taking a look at it sooner) and I see exactly what you're talking >> > about. We can easily move this logic into a func

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-02 Thread Brandon Williams
On 12/01, Jeff King wrote: > On Thu, Dec 01, 2016 at 03:26:56PM -0800, Brandon Williams wrote: > > > > I started taking a look at your http redirect series (I really should > > > have taking a look at it sooner) and I see exactly what you're talking > > > about. We can easily move this logic into

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 03:26:56PM -0800, Brandon Williams wrote: > > I started taking a look at your http redirect series (I really should > > have taking a look at it sooner) and I see exactly what you're talking > > about. We can easily move this logic into a function to make it easier > > to

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Brandon Williams
On 12/01, Junio C Hamano wrote: > Brandon Williams writes: > > > I started taking a look at your http redirect series (I really should > > have taking a look at it sooner) and I see exactly what you're talking > > about. We can easily move this logic into a function to make it easier > > to gene

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Junio C Hamano
Brandon Williams writes: > I started taking a look at your http redirect series (I really should > have taking a look at it sooner) and I see exactly what you're talking > about. We can easily move this logic into a function to make it easier > to generate the two whitelists. OK. With both of

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Brandon Williams
On 12/01, Brandon Williams wrote: > On 12/01, Jeff King wrote: > > On Thu, Dec 01, 2016 at 12:25:59PM -0800, Brandon Williams wrote: > > > > > Add the from_user parameter to the 'is_transport_allowed' function. > > > This allows callers to query if a transport protocol is allowed, given > > > that

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Brandon Williams
On 12/01, Jeff King wrote: > On Thu, Dec 01, 2016 at 12:25:59PM -0800, Brandon Williams wrote: > > > Add the from_user parameter to the 'is_transport_allowed' function. > > This allows callers to query if a transport protocol is allowed, given > > that the caller knows that the protocol is coming

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 01, 2016 at 12:25:59PM -0800, Brandon Williams wrote: > >> Add the from_user parameter to the 'is_transport_allowed' function. >> This allows callers to query if a transport protocol is allowed, given >> that the caller knows that the protocol is coming from the us

Re: [PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 12:25:59PM -0800, Brandon Williams wrote: > Add the from_user parameter to the 'is_transport_allowed' function. > This allows callers to query if a transport protocol is allowed, given > that the caller knows that the protocol is coming from the user (1) or > not from the u

[PATCH v7 4/4] transport: add from_user parameter to is_transport_allowed

2016-12-01 Thread Brandon Williams
Add the from_user parameter to the 'is_transport_allowed' function. This allows callers to query if a transport protocol is allowed, given that the caller knows that the protocol is coming from the user (1) or not from the user (0), such as redirects in libcurl. If unknown, a -1 should be provided