Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit

2014-07-13 Thread Eric Sunshine
On Sun, Jul 13, 2014 at 1:22 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >>> + (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit >>> --interactive -m foo >> >> Broken &&-chain. >> >> Would a printf make this more readable? >> >> printf "p\n1\n\ns\nn\ny\nq\n" |

Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit

2014-07-13 Thread Junio C Hamano
Eric Sunshine writes: >> + (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit >> --interactive -m foo > > Broken &&-chain. > > Would a printf make this more readable? > > printf "p\n1\n\ns\nn\ny\nq\n" | git commt ... && > > Perhaps not. But printf "%s\n" p 1

Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit

2014-07-11 Thread Eric Sunshine
On Fri, Jul 11, 2014 at 7:22 PM, David Turner wrote: > During the commit process, update the cache-tree. Write this updated > cache-tree so that it's ready for subsequent commands. > > Add test code which demonstrates that git commit now writes the cache > tree. Make all tests test the entire cac

[PATCH v7 4/4] cache-tree: Write updated cache-tree after commit

2014-07-11 Thread David Turner
During the commit process, update the cache-tree. Write this updated cache-tree so that it's ready for subsequent commands. Add test code which demonstrates that git commit now writes the cache tree. Make all tests test the entire cache-tree, not just the root level. Signed-off-by: David Turner