Re: [PATCH v7 3/5] bisect: simplify the addition of new bisect terms

2015-06-23 Thread Matthieu Moy
Eric Sunshine writes: > On Tue, Jun 23, 2015 at 8:54 AM, Matthieu Moy wrote: >> + strbuf_addstr(&bisect_refs_buf, "refs/bisect/"); >> + strbuf_addstr(&bisect_refs_buf, name_bad); > > A single strbuf_addf() rather than two strbuf_addstr()s? >> + bisect_refs_str = strbuf_detach

Re: [PATCH v7 3/5] bisect: simplify the addition of new bisect terms

2015-06-23 Thread Eric Sunshine
On Tue, Jun 23, 2015 at 8:54 AM, Matthieu Moy wrote: > diff --git a/revision.c b/revision.c > index 3ff8723..f22923f 100644 > --- a/revision.c > +++ b/revision.c > @@ -2076,14 +2079,32 @@ void parse_revision_opt(struct rev_info *revs, struct > parse_opt_ctx_t *ctx, > ctx->argc -= n; > }

[PATCH v7 3/5] bisect: simplify the addition of new bisect terms

2015-06-23 Thread Matthieu Moy
From: Antoine Delaite We create a file BISECT_TERMS in the repository .git to be read during a bisection. The fonctions to be changed if we add new terms are quite few. In git-bisect.sh : check_and_set_terms bisect_voc Co-authored-by: Louis Stuber Tweaked-by: Matthieu Moy Signe