Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Junio C Hamano
Matthieu Moy writes: > I don't get it. It Git Mediawiki's tests, the tests scripts source > test-lib.sh, that unsets GITPERLLIB. Then, it calls the > mw-to-git/bin-wrapper/git that sets it properly, and calls the > toplevel's bin-wrapper. Ah, OK. I somehow was assuming that a wrapper sets GITPE

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> benoit.per...@ensimag.fr writes: >> >>> diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh >>> index 53a8dd0..dbebe49 100644 >>> --- a/wrap-for-bin.sh >>> +++ b/wrap-for-bin.sh >>> @@ -14,7 +14,7 @@ else >>> GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templ

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Junio C Hamano
Matthieu Moy writes: > benoit.per...@ensimag.fr writes: > >> diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh >> index 53a8dd0..dbebe49 100644 >> --- a/wrap-for-bin.sh >> +++ b/wrap-for-bin.sh >> @@ -14,7 +14,7 @@ else >> GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt' >> export GIT_TEMPLA

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Matthieu Moy
benoit.per...@ensimag.fr writes: > diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh > index 53a8dd0..dbebe49 100644 > --- a/wrap-for-bin.sh > +++ b/wrap-for-bin.sh > @@ -14,7 +14,7 @@ else > GIT_TEMPLATE_DIR='@@BUILD_DIR@@/templates/blt' > export GIT_TEMPLATE_DIR > fi > -GITPERLLIB='@@B

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Michael Haggerty
On 07/03/2013 12:39 AM, benoit.per...@ensimag.fr wrote: > From: Benoit Person > > For now, bin-wrappers (based on wrap-for-bin.sh) redefine some > environnement variables (like $GITPERLLIB). If we want to chain to > those scripts and define one of those variables before, our changes > will be ove

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Benoît Person
>> For now, GITPERLLIB is only used in that kind of statements: >> use lib (split(/:/, $ENV{GITPERLLIB} || ... )); >> >> The trailing ':' does not really matter, split will ignore it. > > That may be true with the current use, but "For now" leaves funny > taste, doesn't it? definitely. For me, the

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-03 Thread Junio C Hamano
Benoît Person writes: >> Do we want to add that ':' unconditionally? Could GITPERLLIB be >> empty? > > For now, GITPERLLIB is only used in that kind of statements: > use lib (split(/:/, $ENV{GITPERLLIB} || ... )); > > The trailing ':' does not really matter, split will ignore it. That may be tr

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-02 Thread Benoît Person
> Do we want to add that ':' unconditionally? Could GITPERLLIB be > empty? For now, GITPERLLIB is only used in that kind of statements: use lib (split(/:/, $ENV{GITPERLLIB} || ... )); The trailing ':' does not really matter, split will ignore it. With the current codebase, I think it's nicer to

Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-02 Thread Junio C Hamano
benoit.per...@ensimag.fr writes: > From: Benoit Person > > For now, bin-wrappers (based on wrap-for-bin.sh) redefine some > environnement variables (like $GITPERLLIB). If we want to chain to > those scripts and define one of those variables before, our changes > will be overwritten. > > This patc

[PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

2013-07-02 Thread benoit . person
From: Benoit Person For now, bin-wrappers (based on wrap-for-bin.sh) redefine some environnement variables (like $GITPERLLIB). If we want to chain to those scripts and define one of those variables before, our changes will be overwritten. This patch simply makes the bin-wrappers prepend their mo