Re: [PATCH v7 1/8] refs.c: add err arguments to reflog functions

2015-07-08 Thread David Turner
On Wed, 2015-07-08 at 13:36 +0200, Michael Haggerty wrote: > On 07/08/2015 02:55 AM, David Turner wrote: > > Add an err argument to log_ref_setup that can explain the reason > > for a failure. This then eliminates the need to manage errno through > > this function since we can just add strerror(err

Re: [PATCH v7 1/8] refs.c: add err arguments to reflog functions

2015-07-08 Thread Michael Haggerty
On 07/08/2015 02:55 AM, David Turner wrote: > Add an err argument to log_ref_setup that can explain the reason > for a failure. This then eliminates the need to manage errno through > this function since we can just add strerror(errno) to the err string > when meaningful. No callers relied on errno

[PATCH v7 1/8] refs.c: add err arguments to reflog functions

2015-07-07 Thread David Turner
Add an err argument to log_ref_setup that can explain the reason for a failure. This then eliminates the need to manage errno through this function since we can just add strerror(errno) to the err string when meaningful. No callers relied on errno from this function for anything else than the error