Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

2019-02-18 Thread Nickolai Belakovski
Well, it sounded like we didn't like the ":" extender from another conversation on this thread. Do you think this patch should move back in that direction? On Tue, Feb 5, 2019 at 3:14 AM Junio C Hamano wrote: > > Nickolai Belakovski writes: > > > There's been a little back and forth on it, but m

Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

2019-02-04 Thread Junio C Hamano
Nickolai Belakovski writes: > There's been a little back and forth on it, but my understanding is > that using the colon separator bypasses the caching mechanism in the > atoms, so every instance of "worktree:path" in a format string would > require a lookup. Would that be a problem, though? Yo

Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

2019-02-01 Thread Junio C Hamano
nbelakov...@gmail.com writes: > +static void lazy_init_worktree_map(void) > +{ > + if (ref_to_worktree_map.worktrees) > + return; > + > + ref_to_worktree_map.worktrees = get_worktrees(0); > + hashmap_init(&(ref_to_worktree_map.map), ref_to_worktree_map_cmpfnc, > NULL, 0);

Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

2019-02-01 Thread Nickolai Belakovski
On Fri, Feb 1, 2019 at 2:20 PM Eric Sunshine wrote: > > On Fri, Feb 1, 2019 at 5:04 PM wrote: > > Add an atom providing the path of the linked worktree where this ref is > > checked out, if it is checked out in any linked worktrees, and empty > > string otherwise. > > > > Signed-off-by: Nickolai

Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

2019-02-01 Thread Eric Sunshine
On Fri, Feb 1, 2019 at 5:04 PM wrote: > Add an atom providing the path of the linked worktree where this ref is > checked out, if it is checked out in any linked worktrees, and empty > string otherwise. > > Signed-off-by: Nickolai Belakovski > --- > diff --git a/Documentation/git-for-each-ref.txt

[PATCH v7 1/3] ref-filter: add worktreepath atom

2019-02-01 Thread nbelakovski
From: Nickolai Belakovski Add an atom providing the path of the linked worktree where this ref is checked out, if it is checked out in any linked worktrees, and empty string otherwise. Signed-off-by: Nickolai Belakovski --- Documentation/git-for-each-ref.txt | 5 +++ ref-filter.c