Re: [PATCH v7 1/2] Add xpread() and xpwrite()

2014-04-10 Thread Yiannis Marangos
On Thu, Apr 10, 2014 at 11:35:42AM -0700, Junio C Hamano wrote: > We do not even use pwrite(); please don't add anything unnecessary > and unexercised, like xpwrite(), as potential bugs in it will go > unnoticed long after its introduction until it first gets used. Correct, my mistake. -- To unsub

Re: [PATCH v7 1/2] Add xpread() and xpwrite()

2014-04-10 Thread Junio C Hamano
Yiannis Marangos writes: > xpread() and xpwrite() pay attention to EAGAIN/EINTR, so they will resume > automatically on interrupted call. We do not even use pwrite(); please don't add anything unnecessary and unexercised, like xpwrite(), as potential bugs in it will go unnoticed long after its i

[PATCH v7 1/2] Add xpread() and xpwrite()

2014-04-10 Thread Yiannis Marangos
xpread() and xpwrite() pay attention to EAGAIN/EINTR, so they will resume automatically on interrupted call. Signed-off-by: Yiannis Marangos --- builtin/index-pack.c | 2 +- compat/mmap.c| 4 +--- git-compat-util.h| 2 ++ wrapper.c| 36 +