Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-07-07 Thread Matthieu Moy
Torsten Bögershausen writes: > #!/usr/bin/perl > > Should we have hard-coded PATH to perl here ? This is what is done in other tests: $ head t*/test.pl -n 1 ==> t0202/test.pl <== #!/usr/bin/perl ==> t9000/test.pl <== #!/usr/bin/perl ==> t9700/test.pl <== #!/usr/bin/perl We actually don't use

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-07-07 Thread Torsten Bögershausen
#!/usr/bin/perl Should we have hard-coded PATH to perl here ? /usr/bin/perl --version This is perl, v5.10.0 built for darwin-thread-multi-2level (with 2 registered patches, see perl -V for more detail) > + > +my $is_passing = Test::More->builder->is_passing; > +exit($is_passing ? 0 : 1); > Thi

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-07-01 Thread Matthieu Moy
Remi Lespinet writes: >> I'd vote for keeping it simple and not having the copyright notice. Most >> t/*.sh do not have one. The Git history + mailing-list archives are much >> better than in-code comments to keep track of who wrote what. > >> Remi: any objection on removing it? > > Sorry for not

[PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-07-01 Thread Remi Lespinet
> I'd vote for keeping it simple and not having the copyright notice. Most > t/*.sh do not have one. The Git history + mailing-list archives are much > better than in-code comments to keep track of who wrote what. > Remi: any objection on removing it? Sorry for not having resent the patches mysel

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-06-30 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> Matthieu Moy writes: >> >>> diff --git a/t/t9000-addresses.sh b/t/t9000-addresses.sh >>> new file mode 100755 >>> index 000..7223d03 >>> --- /dev/null >>> +++ b/t/t9000-addresses.sh >>> @@ -0,0 +1,30 @@ >>> +#!/bin/sh >>> +# >>> +# Copyrigh

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-06-30 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> diff --git a/t/t9000-addresses.sh b/t/t9000-addresses.sh >> new file mode 100755 >> index 000..7223d03 >> --- /dev/null >> +++ b/t/t9000-addresses.sh >> @@ -0,0 +1,30 @@ >> +#!/bin/sh >> +# >> +# Copyright (c) 2015 > > That does not look lik

Re: [PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-06-30 Thread Junio C Hamano
Matthieu Moy writes: > diff --git a/t/t9000-addresses.sh b/t/t9000-addresses.sh > new file mode 100755 > index 000..7223d03 > --- /dev/null > +++ b/t/t9000-addresses.sh > @@ -0,0 +1,30 @@ > +#!/bin/sh > +# > +# Copyright (c) 2015 That does not look like a valid copyright notice. In the mode

[PATCH v7 07/10] send-email: reduce dependencies impact on parse_address_line

2015-06-30 Thread Matthieu Moy
From: Remi Lespinet parse_address_line had not the same behavior whether the user had Mail::Address or not. Teach parse_address_line to behave like Mail::Address. When the user input is correct, this implementation behaves exactly like Mail::Address except when there are quotes inside the name: