Re: [PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-20 Thread Junio C Hamano
Junio C Hamano writes: > Ben Peart writes: > >> On 9/20/2017 9:46 PM, Junio C Hamano wrote: >>> Ben Peart writes: >>> Lets see how my ascii art skills do at describing this: >>> >>> Your ascii art is fine. If you said upfront that the capital >>> letters signify points in time, lower lett

Re: [PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-20 Thread Junio C Hamano
Ben Peart writes: > On 9/20/2017 9:46 PM, Junio C Hamano wrote: >> Ben Peart writes: >> >>> Lets see how my ascii art skills do at describing this: >> >> Your ascii art is fine. If you said upfront that the capital >> letters signify points in time, lower letters are file-touching >> events, an

Re: [PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-20 Thread Ben Peart
On 9/20/2017 9:46 PM, Junio C Hamano wrote: Ben Peart writes: Lets see how my ascii art skills do at describing this: Your ascii art is fine. If you said upfront that the capital letters signify points in time, lower letters are file-touching events, and time flows from left to right, it

Re: [PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-20 Thread Junio C Hamano
Ben Peart writes: > Lets see how my ascii art skills do at describing this: Your ascii art is fine. If you said upfront that the capital letters signify points in time, lower letters are file-touching events, and time flows from left to right, it would have been perfect ;-) > There is no real

Re: [PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-20 Thread Ben Peart
On 9/20/2017 1:47 AM, Junio C Hamano wrote: Ben Peart writes: + OPT_SET_INT(0, "force-write-index", &force_write, + N_("write out the index even if is not flagged as changed"), 1), Hmph. The only time this makes difference is when the code forgets to m

Re: [PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-19 Thread Junio C Hamano
Ben Peart writes: > + OPT_SET_INT(0, "force-write-index", &force_write, > + N_("write out the index even if is not flagged as > changed"), 1), Hmph. The only time this makes difference is when the code forgets to mark active_cache_changed even when it actually m

[PATCH v7 03/12] update-index: add a new --force-write-index option

2017-09-19 Thread Ben Peart
At times, it makes sense to avoid the cost of writing out the index when the only changes can easily be recomputed on demand. This causes problems when trying to write test cases to verify that state as they can't guarantee the state has been persisted to disk. Add a new option (--force-write-inde