Re: [PATCH v7 00/31] Support multiple checkouts

2014-07-14 Thread Junio C Hamano
Duy Nguyen writes: > On Mon, Jul 14, 2014 at 11:45 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> fd = open(git_path("repos/%s/gitdir", id), O_RDONLY); >>> ... >>> - while (path[len - 1] == '\n' || path[len - 1] == '\r') >>> + while (len && (path[len - 1] == '\n

Re: [PATCH v7 00/31] Support multiple checkouts

2014-07-14 Thread Duy Nguyen
On Mon, Jul 14, 2014 at 11:45 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> fd = open(git_path("repos/%s/gitdir", id), O_RDONLY); >> ... >> - while (path[len - 1] == '\n' || path[len - 1] == '\r') >> + while (len && (path[len - 1] == '\n' || path[len - 1] == '\r'))

Re: [PATCH v7 00/31] Support multiple checkouts

2014-07-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > fd = open(git_path("repos/%s/gitdir", id), O_RDONLY); > ... > - while (path[len - 1] == '\n' || path[len - 1] == '\r') > + while (len && (path[len - 1] == '\n' || path[len - 1] == '\r')) > len--; Do we anticipate (or even allow/endorse)

[PATCH v7 00/31] Support multiple checkouts

2014-07-12 Thread Nguyễn Thái Ngọc Duy
v7 fixes all comments from Eric and Max. Jeff's two patches are dropped because they have landed in latest master now. Diff against v6: diff --git a/Documentation/config.txt b/Documentation/config.txt index 470f979..57999fa 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -1