Re: [PATCH v6 8/8] fetch-pack: implement ref-in-want

2018-07-23 Thread Jonathan Nieder
Hi, Duy Nguyen wrote: > On Mon, Jul 23, 2018 at 7:53 PM Brandon Williams wrote: >> What criteria is used to determine if something should be translated? [...] > Besides drawing the line "benefit from (not) being translated" varies > from one developer to another. I think it's just easier and mor

Re: [PATCH v6 8/8] fetch-pack: implement ref-in-want

2018-07-23 Thread Duy Nguyen
On Mon, Jul 23, 2018 at 7:53 PM Brandon Williams wrote: > > On 07/22, Duy Nguyen wrote: > > On Thu, Jun 28, 2018 at 12:33 AM Brandon Williams wrote: > > > +static void receive_wanted_refs(struct packet_reader *reader, struct ref > > > *refs) > > > +{ > > > + process_section_header(reader,

Re: [PATCH v6 8/8] fetch-pack: implement ref-in-want

2018-07-23 Thread Brandon Williams
On 07/22, Duy Nguyen wrote: > On Thu, Jun 28, 2018 at 12:33 AM Brandon Williams wrote: > > +static void receive_wanted_refs(struct packet_reader *reader, struct ref > > *refs) > > +{ > > + process_section_header(reader, "wanted-refs", 0); > > + while (packet_reader_read(reader) == PAC

Re: [PATCH v6 8/8] fetch-pack: implement ref-in-want

2018-07-22 Thread Duy Nguyen
On Thu, Jun 28, 2018 at 12:33 AM Brandon Williams wrote: > +static void receive_wanted_refs(struct packet_reader *reader, struct ref > *refs) > +{ > + process_section_header(reader, "wanted-refs", 0); > + while (packet_reader_read(reader) == PACKET_READ_NORMAL) { > + str

[PATCH v6 8/8] fetch-pack: implement ref-in-want

2018-06-27 Thread Brandon Williams
Implement ref-in-want on the client side so that when a server supports the "ref-in-want" feature, a client will send "want-ref" lines for each reference the client wants to fetch. This feature allows clients to tolerate inconsistencies that exist when a remote repository's refs change during the