Re: [PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-08-01 Thread Jeff King
On Thu, Aug 01, 2013 at 10:25:13AM -0700, Junio C Hamano wrote: > > diff --git a/builtin/config.c b/builtin/config.c > > index c35c5be..9328a90 100644 > > --- a/builtin/config.c > > +++ b/builtin/config.c > > @@ -589,7 +589,9 @@ int cmd_config(int argc, const char **argv, const char > > *prefix)

Re: [PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-08-01 Thread Junio C Hamano
Jeff King writes: > That being said, git-config _should_ be lowercasing to match the normal > --get code path. I think the fix (squashable on top of 6/6 + my earlier > patch) is just: > > diff --git a/builtin/config.c b/builtin/config.c > index c35c5be..9328a90 100644 > --- a/builtin/config.c > +

Re: [PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-07-31 Thread Junio C Hamano
Jeff King writes: > 1. Git-config expects pre-canonicalized variable names (so http.noepsv > instead of "http.noEPSV"). I think the "git config --get" code path > does this for the caller, so we should probably do the same for > "--get-urlmatch". And it is even easier here, becau

Re: [PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-07-31 Thread Jeff King
On Wed, Jul 31, 2013 at 04:03:01PM -0700, Kyle J. McKay wrote: > > 1. Git-config expects pre-canonicalized variable names (so > >http.noepsv > >instead of "http.noEPSV"). I think the "git config --get" code > >path > >does this for the caller, so we should probably do the same for > >"

Re: [PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-07-31 Thread Kyle J. McKay
On Jul 31, 2013, at 15:45, Jeff King wrote: On Wed, Jul 31, 2013 at 12:26:08PM -0700, Junio C Hamano wrote: Using the same urlmatch_config_entry() infrastructure, add a new mode "--get-urlmatch" to the "git config" command, to learn values for the "virtual" two-level variables customized for t

Re: [PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-07-31 Thread Jeff King
On Wed, Jul 31, 2013 at 12:26:08PM -0700, Junio C Hamano wrote: > Using the same urlmatch_config_entry() infrastructure, add a new > mode "--get-urlmatch" to the "git config" command, to learn values > for the "virtual" two-level variables customized for the specific > URL. > > git config [--

[PATCH v6 6/6] config: "git config --get-urlmatch" parses section..key

2013-07-31 Thread Junio C Hamano
Using the same urlmatch_config_entry() infrastructure, add a new mode "--get-urlmatch" to the "git config" command, to learn values for the "virtual" two-level variables customized for the specific URL. git config [--] --get-urlmatch [.] With . fully specified, the configuration data for ..