Re: [PATCH v6 4/6] blame: add config options to handle output for ignored lines

2019-04-15 Thread Barret Rhoden
Hi - On 4/14/19 7:27 AM, Michael Platings wrote: On Sun, 14 Apr 2019 at 11:24, Junio C Hamano wrote: If you only enable blame.markIgnoredLines then the hash for "unblamable" lines appears as e.g. "*3252488f5" - this doesn't seem right to me because the commit *wasn't* ignored, I think you mi

Re: [PATCH v6 4/6] blame: add config options to handle output for ignored lines

2019-04-14 Thread Michael Platings
On Sun, 14 Apr 2019 at 11:24, Junio C Hamano wrote: > > If you only enable blame.markIgnoredLines then the hash for > > "unblamable" lines appears as e.g. "*3252488f5" - this doesn't seem > > right to me because the commit *wasn't* ignored, > > I think you misunderstood me. I was merely suggestin

Re: [PATCH v6 4/6] blame: add config options to handle output for ignored lines

2019-04-14 Thread Junio C Hamano
Michael Platings writes: > If you only enable blame.markIgnoredLines then the hash for > "unblamable" lines appears as e.g. "*3252488f5" - this doesn't seem > right to me because the commit *wasn't* ignored, I think you misunderstood me. I was merely suggesting to use the approach to mark the l

Re: [PATCH v6 4/6] blame: add config options to handle output for ignored lines

2019-04-14 Thread Michael Platings
On Sun, 14 Apr 2019 at 04:45, Junio C Hamano wrote: > Wouldn't this make it impossible to tell between what's done by such > a commit that was marked to be ignored, and what's done locally only > in the working tree, which the users have long accustomed to see > with the ^0*$ object name? I think

Re: [PATCH v6 4/6] blame: add config options to handle output for ignored lines

2019-04-13 Thread Junio C Hamano
Barret Rhoden writes: > Sometimes we are unable to even guess at what commit touched a line. > These lines are 'unblamable.' The second option, > blame.maskIgnoredUnblamables, will zero the hash of any unblamable line. > > For example, say we ignore e5e8d36d04cbe: > e5e8d36d04cbe (Barret R

[PATCH v6 4/6] blame: add config options to handle output for ignored lines

2019-04-10 Thread Barret Rhoden
When ignoring commits, the commit that is blamed might not be responsible for the change. Users might want to know when a particular line has a potentially inaccurate blame. Furthermore, they might never want to see the object hash of an ignored commit. This patch adds two config options to cont