On Mon, 2016-02-29 at 17:21 -0500, Jeff King wrote:
> On Mon, Feb 29, 2016 at 05:10:24PM -0500, Jeff King wrote:
>
> > > We apparently don't always call check_repo_format before calling
> > > git_config_early -- or, more to the point, before doing ref
> > > operations.
> > > So I think we need thi
On Mon, Feb 29, 2016 at 05:10:24PM -0500, Jeff King wrote:
> > We apparently don't always call check_repo_format before calling
> > git_config_early -- or, more to the point, before doing ref operations.
> > So I think we need this in git_config_early.
>
> That seems horribly broken, though. If a
On Mon, Feb 29, 2016 at 04:57:49PM -0500, David Turner wrote:
> > By the way, I notice that the default value for the_refs_backend is
> > "&refs_be_files". It might be safer to make this NULL (or some
> > &refs_be_null that fills the vtable, but just returns an error for
> > each
> > call).
>
> I
On Mon, Feb 29, 2016 at 04:57:42PM -0500, David Turner wrote:
> > So I think this setup probably should be in
> > check_repository_format_gently(), and should be able to trigger off
> > of
> > the existing ref_storage_backend string we've already saved (and we
> > should bail immediately there if
On Fri, 2016-02-26 at 22:56 -0500, Jeff King wrote:
> On Wed, Feb 24, 2016 at 05:59:00PM -0500, David Turner wrote:
>
> > @@ -1207,6 +1208,29 @@ int git_config_early(config_fn_t fn, void
> > *data, const char *repo_config)
> > }
> >
> > if (repo_config && !access_or_die(repo_config, R_OK
On Fri, 2016-02-26 at 23:14 -0500, Jeff King wrote:
> On Fri, Feb 26, 2016 at 10:56:34PM -0500, Jeff King wrote:
>
> > My second confusion is why this is happening in git_config_early().
> > That
> > function is called during the setup of
> > check_repository_format_gently(),
> > which is why I th
On Fri, Feb 26, 2016 at 10:56:34PM -0500, Jeff King wrote:
> My second confusion is why this is happening in git_config_early(). That
> function is called during the setup of check_repository_format_gently(),
> which is why I think you wanted to put the code here. But it's _also_
> called as part
On Wed, Feb 24, 2016 at 05:59:00PM -0500, David Turner wrote:
> @@ -1207,6 +1208,29 @@ int git_config_early(config_fn_t fn, void *data, const
> char *repo_config)
> }
>
> if (repo_config && !access_or_die(repo_config, R_OK, 0)) {
> + char *storage = NULL;
> +
> +
This sets up the existing backend early, so that other code which
reads refs is reading from the right place.
Signed-off-by: David Turner
---
config.c | 24
1 file changed, 24 insertions(+)
diff --git a/config.c b/config.c
index b95ac3a..6cea884 100644
--- a/config.c
++
9 matches
Mail list logo
