Re: [PATCH v6 20/42] fetch.c: clear errno before calling functions that might set it

Fixed. Thanks. On Thu, May 1, 2014 at 9:11 PM, Eric Sunshine wrote: > On Thu, May 1, 2014 at 4:37 PM, Ronnie Sahlberg wrote: >> In s_update_ref there are two calls that when they fail we return an error >> based on the errno value. In particular we want to return a specific error >> if ENOTDIR h

Re: [PATCH v6 20/42] fetch.c: clear errno before calling functions that might set it

On Thu, May 1, 2014 at 4:37 PM, Ronnie Sahlberg wrote: > In s_update_ref there are two calls that when they fail we return an error > based on the errno value. In particular we want to return a specific error > if ENOTDIR happened. Both these functions do have failure modes where they > may return

[PATCH v6 20/42] fetch.c: clear errno before calling functions that might set it

In s_update_ref there are two calls that when they fail we return an error based on the errno value. In particular we want to return a specific error if ENOTDIR happened. Both these functions do have failure modes where they may return an error without updating errno, in which case a previous and u