On 2/5/2019 2:52 PM, Ævar Arnfjörð Bjarmason wrote:
> From: William Hubbs
> -const char *fmt_name(const char *name, const char *email)
> +const char *fmt_name(enum want_ident whose_ident)
> {
> - return fmt_ident(name, email, NULL, IDENT_STRICT | IDENT_NO_DATE);
> + char *name = NULL;
> +
On Wed, Feb 13, 2019 at 02:37:48PM -0800, Junio C Hamano wrote:
> William Hubbs writes:
>
> > I am writing back onn this thread because I'm not quite sure of the
> > status. v5 of the patch seemed ok, but there were some changes discussed
> > that would have created a v6. The v6 changes though we
William Hubbs writes:
> I am writing back onn this thread because I'm not quite sure of the
> status. v5 of the patch seemed ok, but there were some changes discussed
> that would have created a v6. The v6 changes though were never really
> clear. I'm not sure whether I am supposed to be doing so
Hi Junio,
I am writing back onn this thread because I'm not quite sure of the
status. v5 of the patch seemed ok, but there were some changes discussed
that would have created a v6. The v6 changes though were never really
clear. I'm not sure whether I am supposed to be doing something more or
wheth
Jeff King writes:
> An alternative view is that anybody who calls git_author_info() to
> create a commit _should_ be checking author_ident_sufficiently_given(),
> and it's a bug that they're not.
>
> I.e., should we be doing something like this (and probably some other
> spots, too):
>
> diff --g
On Wed, Feb 06, 2019 at 01:26:12PM -0500, Jeff King wrote:
> On Wed, Feb 06, 2019 at 10:28:34AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> > I did some further digging. One of the confusing things is that we've
> > been carrying dead code since 2012 to set this
> > author_ident_explicitly_given var
On Wed, Feb 06, 2019 at 10:28:34AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> William, is that something you're intererested in carrying forward? I
> can also help if you want. Sorry your first contribution to git has
> turned into this mess of re-rolls, as often happens we find that when
> trying
On Wed, Feb 06, 2019 at 10:28:34AM +0100, Ævar Arnfjörð Bjarmason wrote:
> I did some further digging. One of the confusing things is that we've
> been carrying dead code since 2012 to set this
> author_ident_explicitly_given variable. We can just apply this on top of
> master:
> [...]
> @@ -4
On Tue, Feb 05 2019, Ævar Arnfjörð Bjarmason wrote:
> On Tue, Feb 05 2019, Junio C Hamano wrote:
>
>> Ævar Arnfjörð Bjarmason writes:
>>
>>> +static int set_ident_internal(const char *var, const char *value,
>>> + struct strbuf *sb, const int flag)
>>> +{
>>> + if (!val
On Wed, Feb 06 2019, William Hubbs wrote:
> On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
>>
>> On Tue, Feb 05 2019, Junio C Hamano wrote:
>>
>> > Ævar Arnfjörð Bjarmason writes:
>> >
>> >> +static int set_ident_internal(const char *var, const char *value,
>> >> +
William Hubbs writes:
> I attempted to save your patches to apply them, but didn't have any luck
I'll push a topic branch (not merged to any of the integration
branches) ab/author-committer-ident-config later today at the
https://github.com/gitster/git repository.
> Also, according to Junio's r
On Tue, Feb 05, 2019 at 06:15:58PM -0600, William Hubbs wrote:
> On Tue, Feb 05, 2019 at 06:04:13PM -0600, William Hubbs wrote:
> > On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
> > >
> > > On Tue, Feb 05 2019, Junio C Hamano wrote:
> > >
> > > > Ævar Arnfjörð Bjarmason
On Tue, Feb 05, 2019 at 06:04:13PM -0600, William Hubbs wrote:
> On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
> >
> > On Tue, Feb 05 2019, Junio C Hamano wrote:
> >
> > > Ævar Arnfjörð Bjarmason writes:
> > >
> > >> +static int set_ident_internal(const char *var, con
On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, Feb 05 2019, Junio C Hamano wrote:
>
> > Ævar Arnfjörð Bjarmason writes:
> >
> >> +static int set_ident_internal(const char *var, const char *value,
> >> + struct strbuf *sb, const int flag
On Tue, Feb 05 2019, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
>> +static int set_ident_internal(const char *var, const char *value,
>> +struct strbuf *sb, const int flag)
>> +{
>> +if (!value)
>> +return config_error_nonbool(var);
>> +
Ævar Arnfjörð Bjarmason writes:
> +static int set_ident_internal(const char *var, const char *value,
> + struct strbuf *sb, const int flag)
> +{
> + if (!value)
> + return config_error_nonbool(var);
> + strbuf_reset(sb);
> + strbuf_addstr(sb, value
From: William Hubbs
The author.email, author.name, committer.email and committer.name
settings are analogous to the GIT_AUTHOR_* and GIT_COMMITTER_*
environment variables, but for the git config system. This allows them
to be set separately for each repository.
Git supports setting different aut
17 matches
Mail list logo
