> > > +void get_client_protocol_version_advertisement(struct strbuf *advert)
> > > +{
> > > + int i, tmp_nr = nr_allowed_versions;
> > > + enum protocol_version *tmp_allowed_versions, config_version;
> > > + strbuf_reset(advert);
> > > +
> > > + version_registration_locked = 1;
> > > +
> >
On 2019.02.05 11:42, Jonathan Tan wrote:
> Thanks. Overall, one major point: I think that the declaration of
> supported versions need to be transport-scoped (search this email for
> "transport-scoped" for context). And one medium point: it might be
> better for protocol.version to be the preferred
Thanks. Overall, one major point: I think that the declaration of
supported versions need to be transport-scoped (search this email for
"transport-scoped" for context). And one medium point: it might be
better for protocol.version to be the preferred and maximum version, not
only the preferred vers
Currently the client advertises that it supports the wire protocol
version set in the protocol.version config. However, not all services
support the same set of protocol versions. For example, git-receive-pack
supports v1 and v0, but not v2. If a client connects to git-receive-pack
and requests v2,
4 matches
Mail list logo
