Re: [PATCH v6 1/1] http: add support selecting http version

2018-11-08 Thread Junio C Hamano
Eric Sunshine writes: >> @@ -284,6 +285,9 @@ static void process_curl_messages(void) >> static int http_options(const char *var, const char *value, void *cb) >> { >> + if (!strcmp("http.version",var)) { > > Style: space after comma > >> + return git_config_string(&curl_http_

Re: [PATCH v6 1/1] http: add support selecting http version

2018-11-08 Thread Junio C Hamano
"Force Charlie via GitGitGadget" writes: > +#if LIBCURL_VERSION_NUM >=0x072f00 > +static int get_curl_http_version_opt(const char *version_string, long *opt) > +{ > + int i; > + static struct { > + const char *name; > + long opt_token; > + } choice[] = { > +

Re: [PATCH v6 1/1] http: add support selecting http version

2018-11-08 Thread Eric Sunshine
On Thu, Nov 8, 2018 at 2:00 AM Force Charlie via GitGitGadget wrote: > In order to give users the freedom to control the HTTP version, > we need to add a setting to choose which HTTP version to use. > > Signed-off-by: Force Charlie > --- > diff --git a/http.c b/http.c > @@ -284,6 +285,9 @@ static

[PATCH v6 1/1] http: add support selecting http version

2018-11-07 Thread Force Charlie via GitGitGadget
From: Force Charlie Usually we don't need to set libcurl to choose which version of the HTTP protocol to use to communicate with a server. But different versions of libcurl, the default value is not the same. CURL >= 7.62.0: CURL_HTTP_VERSION_2TLS CURL < 7.62: CURL_HTTP_VERSION_1_1 In order to