Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue

On 12/05, Jeff Hostetler wrote: > From: Jeff Hostetler > I'm a fan of eliminating looping goto statements. I understand their need for doing cleanup, but I think they should be reserved for that specific case. Thanks for cleaning this up! > Signed-off-by: Jeff Hostetler > --- > sha1_file.c

Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue

On 12/5/2017 3:54 PM, Junio C Hamano wrote: Jeff Hostetler writes: From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- sha1_file.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) The second (i.e. this) part and the third part are no

Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue

Jeff Hostetler writes: > + while (1) { > + if (find_pack_entry(real, &e)) > + break; > > + /* Most likely it's a loose object. */ > + if (!sha1_loose_object_info(real, oi, flags)) > + return 0; > > + /

Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue

Jeff Hostetler writes: > From: Jeff Hostetler > > Signed-off-by: Jeff Hostetler > --- > sha1_file.c | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) The second (i.e. this) part and the third part are not yet in 'next', so it will perfectly be

[PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- sha1_file.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/sha1_file.c b/sha1_file.c index fc7718a..ce67f27 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -1180,30 +1180,30 @@ i