Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-29 Thread Lars Schneider
> On 26 Aug 2016, at 19:15, Junio C Hamano wrote: > > Lars Schneider writes: > >>> Do you anticipate future need of non-gently variant of this >>> function? If so, perhaps a helper that takes a boolean "am I >>> working for the gently variant?" may help share more code. >> >> With helper you

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-26 Thread Junio C Hamano
Lars Schneider writes: >> Do you anticipate future need of non-gently variant of this >> function? If so, perhaps a helper that takes a boolean "am I >> working for the gently variant?" may help share more code. > > With helper you mean "an additional boolean parameter"? I don't > see a need fo

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-26 Thread Lars Schneider
> On 25 Aug 2016, at 23:50, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> packet_write_fmt() has two shortcomings. First, it uses format_packet() >> which lets the caller only send string data via "%s". That means it >> cannot be used for arbitrary

Re: [PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-25 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > > packet_write_fmt() has two shortcomings. First, it uses format_packet() > which lets the caller only send string data via "%s". That means it > cannot be used for arbitrary data that may contain NULs. Second, it will > always die on erro

[PATCH v6 05/13] pkt-line: add packet_write_gently()

2016-08-25 Thread larsxschneider
From: Lars Schneider packet_write_fmt() has two shortcomings. First, it uses format_packet() which lets the caller only send string data via "%s". That means it cannot be used for arbitrary data that may contain NULs. Second, it will always die on error. Add packet_write_gently() which writes ar