Re: [PATCH v6 02/11] trailer: process trailers from stdin and arguments

2014-03-07 Thread Christian Couder
On Fri, Mar 7, 2014 at 9:08 AM, Dan Carpenter wrote: > On Fri, Mar 07, 2014 at 07:19:15AM +0100, Christian Couder wrote: >> >> Yeah, I don't know why, but these days I find it very hard to review >> style issues in my own code without being distracted. >> And by the way is there a good script to c

Re: [PATCH v6 02/11] trailer: process trailers from stdin and arguments

2014-03-07 Thread Dan Carpenter
On Fri, Mar 07, 2014 at 07:19:15AM +0100, Christian Couder wrote: > On Wed, Mar 5, 2014 at 11:52 PM, Junio C Hamano wrote: > > > > This round is marked as the sixth, but I still see quite a many > > style issues, which I expect not to see from long timers without > > being told. Somewhat disappoi

Re: [PATCH v6 02/11] trailer: process trailers from stdin and arguments

2014-03-06 Thread Christian Couder
On Wed, Mar 5, 2014 at 11:52 PM, Junio C Hamano wrote: > > This round is marked as the sixth, but I still see quite a many > style issues, which I expect not to see from long timers without > being told. Somewhat disappointing... Yeah, I don't know why, but these days I find it very hard to revi

Re: [PATCH v6 02/11] trailer: process trailers from stdin and arguments

2014-03-05 Thread Junio C Hamano
Christian Couder writes: > Implement the logic to process trailers from stdin and arguments. > > At the beginning trailers from stdin are in their own in_tok > doubly linked list, and trailers from arguments are in their own > arg_tok doubly linked list. > > The lists are traversed and when an ar

[PATCH v6 02/11] trailer: process trailers from stdin and arguments

2014-03-04 Thread Christian Couder
Implement the logic to process trailers from stdin and arguments. At the beginning trailers from stdin are in their own in_tok doubly linked list, and trailers from arguments are in their own arg_tok doubly linked list. The lists are traversed and when an arg_tok should be "applied", it is remove