Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Adam Spiers
On Thu, Dec 20, 2012 at 7:21 PM, Junio C Hamano wrote: > Jeff King writes: >>> Good point, I forgot to check what it looked like with -v. Since this >>> series is already on v6, is there a more lightweight way of addressing >>> this tiny tweak than sending v7? >> >> It is ultimately up to Junio,

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Jeff King
On Thu, Dec 20, 2012 at 11:21:09AM -0800, Junio C Hamano wrote: > The "expected_failure" cases painted in "warn" are all long-known > failures; I do not think reminding about them in "bold" over and > over will help encouraging the developers take a look at them. > > The "skipped" cases fall into

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Junio C Hamano
Jeff King writes: >> Good point, I forgot to check what it looked like with -v. Since this >> series is already on v6, is there a more lightweight way of addressing >> this tiny tweak than sending v7? > > It is ultimately up to Junio, but I suspect he would be OK if you just > reposted patch 4/7

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Adam Spiers
On Thu, Dec 20, 2012 at 4:11 PM, Jeff King wrote: > On Thu, Dec 20, 2012 at 03:44:53PM +, Adam Spiers wrote: >> > diff --git a/t/test-lib.sh b/t/test-lib.sh >> > index 256f1c6..31f59af 100644 >> > --- a/t/test-lib.sh >> > +++ b/t/test-lib.sh >> > @@ -227,7 +227,7 @@ then >> > p

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Jeff King
On Thu, Dec 20, 2012 at 03:44:53PM +, Adam Spiers wrote: > > diff --git a/t/test-lib.sh b/t/test-lib.sh > > index 256f1c6..31f59af 100644 > > --- a/t/test-lib.sh > > +++ b/t/test-lib.sh > > @@ -227,7 +227,7 @@ then > > pass) > > tput setaf 2;;

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Adam Spiers
On Thu, Dec 20, 2012 at 3:34 PM, Jeff King wrote: > On Sun, Dec 16, 2012 at 07:01:56PM +, Adam Spiers wrote: >> On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano wrote: >> > Adam Spiers writes: >> >> This series of commits attempts to make test output coloring >> >> more intuitive,... >> > >>

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-20 Thread Jeff King
On Sun, Dec 16, 2012 at 07:01:56PM +, Adam Spiers wrote: > On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano wrote: > > Adam Spiers writes: > > > >> This series of commits attempts to make test output coloring > >> more intuitive,... > > > > Thanks; I understand that this is to replace the pre

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-16 Thread Junio C Hamano
Adam Spiers writes: > On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> This series of commits attempts to make test output coloring >>> more intuitive,... >> >> Thanks; I understand that this is to replace the previous one >> b465316 (tests: paint unexpectedl

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-16 Thread Adam Spiers
On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano wrote: > Adam Spiers writes: > >> This series of commits attempts to make test output coloring >> more intuitive,... > > Thanks; I understand that this is to replace the previous one > b465316 (tests: paint unexpectedly fixed known breakages in bold

Re: [PATCH v6 0/7] make test output coloring more intuitive

2012-12-16 Thread Junio C Hamano
Adam Spiers writes: > This series of commits attempts to make test output coloring > more intuitive,... Thanks; I understand that this is to replace the previous one b465316 (tests: paint unexpectedly fixed known breakages in bold red, 2012-09-19)---am I correct? > - red is only used for thin

[PATCH v6 0/7] make test output coloring more intuitive

2012-12-16 Thread Adam Spiers
This series of commits attempts to make test output coloring more intuitive, so that: - red is only used for things which have gone unexpectedly wrong: test failures, unexpected test passes, and failures with the framework, - yellow is only used for known breakages, - green is only