Re: [PATCH v6 0/2] Add support for sending additional HTTP headers

2016-05-04 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Wed, 4 May 2016, Junio C Hamano wrote: > >> Jeff King writes: >> >> >> submodule: pass on http.extraheader config settings >> > >> > IMHO this should come on top of jk/submodule-config-sanitize-fix (I was >> > surprised at first that your test wo

Re: [PATCH v6 0/2] Add support for sending additional HTTP headers

2016-05-04 Thread Johannes Schindelin
Hi Junio, On Wed, 4 May 2016, Junio C Hamano wrote: > Jeff King writes: > > >> submodule: pass on http.extraheader config settings > > > > IMHO this should come on top of jk/submodule-config-sanitize-fix (I was > > surprised at first that your test worked at all, but that is because it > > is

Re: [PATCH v6 0/2] Add support for sending additional HTTP headers

2016-05-04 Thread Jeff King
On Wed, May 04, 2016 at 02:26:18AM -0400, Jeff King wrote: > > submodule: pass on http.extraheader config settings > > IMHO this should come on top of jk/submodule-config-sanitize-fix (I was > surprised at first that your test worked at all, but that is because it > is using "clone", which is t

Re: [PATCH v6 0/2] Add support for sending additional HTTP headers

2016-05-04 Thread Junio C Hamano
Jeff King writes: >> submodule: pass on http.extraheader config settings > > IMHO this should come on top of jk/submodule-config-sanitize-fix (I was > surprised at first that your test worked at all, but that is because it > is using "clone", which is the one code path that works). Yes. > But

Re: [PATCH v6 0/2] Add support for sending additional HTTP headers

2016-05-03 Thread Jeff King
On Wed, May 04, 2016 at 08:14:07AM +0200, Johannes Schindelin wrote: > My use case is an army of build agents that need only limited and > selective access to otherwise private repositories. > > v6 supports submodules better by allowing > > git -c http.extraheader submodule update > > to

[PATCH v6 0/2] Add support for sending additional HTTP headers

2016-05-03 Thread Johannes Schindelin
My use case is an army of build agents that need only limited and selective access to otherwise private repositories. v6 supports submodules better by allowing git -c http.extraheader submodule update to work as one would expect intuitively. Johannes Schindelin (2): http: support send