Re: [PATCH v5 8/8] sha1_file: refactor has_sha1_file_with_flags

2017-07-19 Thread Johannes Schindelin
Hi Jonathan, On Tue, 18 Jul 2017, Jonathan Tan wrote: > On Tue, 18 Jul 2017 12:30:46 +0200 > Christian Couder wrote: > > > On Thu, Jun 22, 2017 at 2:40 AM, Jonathan Tan > > wrote: > > > > > diff --git a/sha1_file.c b/sha1_file.c > > > index bf6b64ec8..778f01d92 100644 > > > --- a/sha1_file.c

Re: [PATCH v5 8/8] sha1_file: refactor has_sha1_file_with_flags

2017-07-18 Thread Jonathan Tan
On Tue, 18 Jul 2017 12:30:46 +0200 Christian Couder wrote: > On Thu, Jun 22, 2017 at 2:40 AM, Jonathan Tan > wrote: > > > diff --git a/sha1_file.c b/sha1_file.c > > index bf6b64ec8..778f01d92 100644 > > --- a/sha1_file.c > > +++ b/sha1_file.c > > @@ -3494,18 +3494,10 @@ int has_sha1_pack(const

Re: [PATCH v5 8/8] sha1_file: refactor has_sha1_file_with_flags

2017-07-18 Thread Christian Couder
On Thu, Jun 22, 2017 at 2:40 AM, Jonathan Tan wrote: > diff --git a/sha1_file.c b/sha1_file.c > index bf6b64ec8..778f01d92 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -3494,18 +3494,10 @@ int has_sha1_pack(const unsigned char *sha1) > > int has_sha1_file_with_flags(const unsigned char *s

[PATCH v5 8/8] sha1_file: refactor has_sha1_file_with_flags

2017-06-21 Thread Jonathan Tan
has_sha1_file_with_flags() implements many mechanisms in common with sha1_object_info_extended(). Make has_sha1_file_with_flags() a convenience function for sha1_object_info_extended() instead. Signed-off-by: Jonathan Tan --- builtin/fetch.c | 10 ++ builtin/index-pack.c | 3 ++- c