Re: [PATCH v5 3/6] worktree: remove force_new_branch from struct add_opts

2018-03-30 Thread Thomas Gummerer
On 03/27, Eric Sunshine wrote: > On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote: > > The 'force_new_branch' flag in 'struct add_opts' is only used inside the > > add function, where we already have the same information stored in the > > 'new_branch_force' variable. Avoid that unnecessary

Re: [PATCH v5 3/6] worktree: remove force_new_branch from struct add_opts

2018-03-27 Thread Eric Sunshine
On Sun, Mar 25, 2018 at 9:49 AM, Thomas Gummerer wrote: > The 'force_new_branch' flag in 'struct add_opts' is only used inside the > add function, where we already have the same information stored in the > 'new_branch_force' variable. Avoid that unnecessary duplication. When I was reviewing your

[PATCH v5 3/6] worktree: remove force_new_branch from struct add_opts

2018-03-25 Thread Thomas Gummerer
The 'force_new_branch' flag in 'struct add_opts' is only used inside the add function, where we already have the same information stored in the 'new_branch_force' variable. Avoid that unnecessary duplication. Signed-off-by: Thomas Gummerer --- builtin/worktree.c | 6 ++ 1 file changed, 2 in