Caleb Thompson writes:
> On Fri, Jun 13, 2014 at 07:41:29PM -0400, Jeff King wrote:
>> On Fri, Jun 13, 2014 at 10:42:26AM -0700, Junio C Hamano wrote:
>>
>> > Jeff King writes:
>> >
>> > > [1] It might make sense for test_set_editor, when run from within a
>> > > test, to behave more like te
On Fri, Jun 13, 2014 at 07:41:29PM -0400, Jeff King wrote:
> On Fri, Jun 13, 2014 at 10:42:26AM -0700, Junio C Hamano wrote:
>
> > Jeff King writes:
> >
> > > [1] It might make sense for test_set_editor, when run from within a
> > > test, to behave more like test_config, and do:
> > >
> > >
On Fri, Jun 13, 2014 at 10:42:26AM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > [1] It might make sense for test_set_editor, when run from within a
> > test, to behave more like test_config, and do:
> >
> > test_when_finished '
> > sane_unset FAKE_EDITOR &&
> >
On Fri, Jun 13, 2014 at 11:36:44AM -0500, Caleb Thompson wrote:
> > Or did you just mean that the new rule is "every test sets the editor as
> > they need", which means that we do not have to worry anymore about
> > polluting the environment for other tests?
>
> That's exactly what I meant. We ca
W dniu 2014-06-13 19:47, Caleb Thompson pisze:
On Fri, Jun 13, 2014 at 07:16:53PM +0200, Jakub Narębski wrote:
W dniu 2014-06-13 18:36, Caleb Thompson pisze:
t/t7507-commit-verbose.sh was using a global test_set_editor call to
build its environment. The $EDITOR being used was not ne
On Fri, Jun 13, 2014 at 07:16:53PM +0200, Jakub Narębski wrote:
> W dniu 2014-06-13 18:36, Caleb Thompson pisze:
> >On Fri, Jun 13, 2014 at 02:59:42AM -0400, Jeff King wrote:
>
> >>[1] It might make sense for test_set_editor, when run from within a
> >> test, to behave more like test_config, an
Jeff King writes:
> [1] It might make sense for test_set_editor, when run from within a
> test, to behave more like test_config, and do:
>
> test_when_finished '
> sane_unset FAKE_EDITOR &&
> sane_unset EDITOR
> '
>
> I don't know if there would be fallouts wit
W dniu 2014-06-13 18:36, Caleb Thompson pisze:
On Fri, Jun 13, 2014 at 02:59:42AM -0400, Jeff King wrote:
[1] It might make sense for test_set_editor, when run from within a
test, to behave more like test_config, and do:
test_when_finished '
sane_unset FAKE_EDITOR &&
On Fri, Jun 13, 2014 at 02:59:42AM -0400, Jeff King wrote:
> On Thu, Jun 12, 2014 at 02:39:01PM -0500, Caleb Thompson wrote:
>
> > t/t7507-commit-verbose.sh was using a global test_set_editor call to
> > build its environment.
> >
> > Improve robustness against global state changes by having only t
On Thu, Jun 12, 2014 at 02:39:01PM -0500, Caleb Thompson wrote:
> t/t7507-commit-verbose.sh was using a global test_set_editor call to
> build its environment.
>
> Improve robustness against global state changes by having only tests
> which intend to use the $EDITOR to check for presence of a dif
t/t7507-commit-verbose.sh was using a global test_set_editor call to
build its environment.
Improve robustness against global state changes by having only tests
which intend to use the $EDITOR to check for presence of a diff in the
editor set up the test-editor to use check-for-diff rather than re
11 matches
Mail list logo
