Re: [PATCH v5 3/3] Retire the scripted difftool

2017-01-19 Thread Johannes Schindelin
Hi Junio, On Thu, 19 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Yep, as Git for Windows v2.11.0 is yesteryear's news, it was probably > > obvious to you that I simply failed to spot and fix that oversight. > > OK, if you want to tweak log message of either 2/3 or 3/3 t

Re: [PATCH v5 3/3] Retire the scripted difftool

2017-01-19 Thread Junio C Hamano
Johannes Schindelin writes: >> Ok, I was mostly reacting to 2/3 while I am reading it: >> >> The reason: this new, experimental, builtin difftool will be shipped as >> part of Git for Windows v2.11.0, to allow for easier large-scale >> testing, but of course as an opt-in feature. >>

Re: [PATCH v5 3/3] Retire the scripted difftool

2017-01-19 Thread Johannes Schindelin
Hi Junio, On Wed, 18 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Hi Junio, > > > > On Tue, 17 Jan 2017, Junio C Hamano wrote: > > > >> Johannes Schindelin writes: > >> > >> > It served its purpose, but now we have a builtin difftool. Time for the > >> > Perl script to

Re: [PATCH v5 3/3] Retire the scripted difftool

2017-01-18 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Tue, 17 Jan 2017, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > It served its purpose, but now we have a builtin difftool. Time for the >> > Perl script to enjoy Florida. >> > >> > Signed-off-by: Johannes Schindelin >> > --- >> >

Re: [PATCH v5 3/3] Retire the scripted difftool

2017-01-18 Thread Johannes Schindelin
Hi Junio, On Tue, 17 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > It served its purpose, but now we have a builtin difftool. Time for the > > Perl script to enjoy Florida. > > > > Signed-off-by: Johannes Schindelin > > --- > > The endgame makes a lot of sense. Both in

Re: [PATCH v5 3/3] Retire the scripted difftool

2017-01-17 Thread Junio C Hamano
Johannes Schindelin writes: > It served its purpose, but now we have a builtin difftool. Time for the > Perl script to enjoy Florida. > > Signed-off-by: Johannes Schindelin > --- The endgame makes a lot of sense. Both in the cover letter and in the previous patch you talk about having both in

[PATCH v5 3/3] Retire the scripted difftool

2017-01-17 Thread Johannes Schindelin
It served its purpose, but now we have a builtin difftool. Time for the Perl script to enjoy Florida. Signed-off-by: Johannes Schindelin --- .gitignore | 1 - Makefile | 1 - builtin/difftool.c