Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-03-03 Thread Michael Haggerty
On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > t/t1406-submodule-ref-store.sh (new +x) | 95 > + > 1 file changed, 95 insertions(+) > create mode 100755 t/t1406-submodule-ref-store.sh I wonder if you could reduc

Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-03-02 Thread Duy Nguyen
On Thu, Mar 2, 2017 at 3:16 PM, Michael Haggerty wrote: > The for-each-ref iteration is defined to be sorted by refname, but it's > true that the for-each-reflog order is undefined. Thanks. I'm going to add a few lines about this near for_each_ref and for_each_reflog() then, assuming that this is

Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-03-02 Thread Michael Haggerty
On 03/02/2017 07:13 AM, Duy Nguyen wrote: > On Wed, Mar 1, 2017 at 10:11 PM, Michael Haggerty > wrote: >> By trial and error, I found that the test succeeds if I comment out the >> "for_each_reflog()" test. By having that test write its results to >> `/tmp` where they won't be deleted, I found th

Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-03-01 Thread Duy Nguyen
On Wed, Mar 1, 2017 at 10:11 PM, Michael Haggerty wrote: > By trial and error, I found that the test succeeds if I comment out the > "for_each_reflog()" test. By having that test write its results to > `/tmp` where they won't be deleted, I found that the problem is that the > `actual` results are

Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-03-01 Thread Michael Haggerty
On 03/01/2017 01:34 PM, Duy Nguyen wrote: > On Wed, Mar 1, 2017 at 12:34 AM, Michael Haggerty > wrote: >> On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: >>> Signed-off-by: Nguyễn Thái Ngọc Duy >>> --- >>> t/t1406-submodule-ref-store.sh (new +x) | 95 >>> + >

Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-03-01 Thread Duy Nguyen
On Wed, Mar 1, 2017 at 12:34 AM, Michael Haggerty wrote: > On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> t/t1406-submodule-ref-store.sh (new +x) | 95 >> + >> 1 file changed, 95 insertions(+) >> create mode

Re: [PATCH v5 24/24] t1406: new tests for submodule ref store

2017-02-28 Thread Michael Haggerty
On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > t/t1406-submodule-ref-store.sh (new +x) | 95 > + > 1 file changed, 95 insertions(+) > create mode 100755 t/t1406-submodule-ref-store.sh > > diff --git a/t/t1406-su

[PATCH v5 24/24] t1406: new tests for submodule ref store

2017-02-22 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- t/t1406-submodule-ref-store.sh (new +x) | 95 + 1 file changed, 95 insertions(+) create mode 100755 t/t1406-submodule-ref-store.sh diff --git a/t/t1406-submodule-ref-store.sh b/t/t1406-submodule-ref-store.sh new file mode 1