Re: [PATCH v5 20/35] api-lockfile: document edge cases

2014-09-23 Thread Michael Haggerty
On 09/17/2014 12:23 AM, Jonathan Nieder wrote: > Michael Haggerty wrote: > >> * Document the behavior of commit_lock_file() when it fails, namely >> that it rolls back the lock_file object and sets errno >> appropriately. >> >> * Document the behavior of rollback_lock_file() when called for a

Re: [PATCH v5 20/35] api-lockfile: document edge cases

2014-09-16 Thread Jonathan Nieder
Michael Haggerty wrote: > * Document the behavior of commit_lock_file() when it fails, namely > that it rolls back the lock_file object and sets errno > appropriately. > > * Document the behavior of rollback_lock_file() when called for a > lock_file object that has already been committed or

[PATCH v5 20/35] api-lockfile: document edge cases

2014-09-16 Thread Michael Haggerty
* Document the behavior of commit_lock_file() when it fails, namely that it rolls back the lock_file object and sets errno appropriately. * Document the behavior of rollback_lock_file() when called for a lock_file object that has already been committed or rolled back, namely that it is a N