Re: [PATCH v5 15/15] config: rename git_config_set_or_die to git_config_set

2016-02-17 Thread Junio C Hamano
Michael Blume writes: [administrivia: please cull unnecessary parts from your quote] >> 1 warning generated. >> AR libgit.a >> LINK git-credential-store >> Undefined symbols for architecture x86_64: >> "_git_config_set_or_die", referenced from: >> _probe_utf8_pathname_composition

Re: [PATCH v5 15/15] config: rename git_config_set_or_die to git_config_set

2016-02-17 Thread Michael Blume
On Wed, Feb 17, 2016 at 12:57 PM, Michael Blume wrote: > On Tue, Feb 16, 2016 at 4:56 AM, Patrick Steinhardt wrote: >> Rename git_config_set_or_die functions to git_config_set, leading >> to the new default behavior of dying whenever a configuration >> error occurs. >> >> By now all callers that

Re: [PATCH v5 15/15] config: rename git_config_set_or_die to git_config_set

2016-02-17 Thread Michael Blume
On Tue, Feb 16, 2016 at 4:56 AM, Patrick Steinhardt wrote: > Rename git_config_set_or_die functions to git_config_set, leading > to the new default behavior of dying whenever a configuration > error occurs. > > By now all callers that shall die on error have been transitioned > to the _or_die vari

[PATCH v5 15/15] config: rename git_config_set_or_die to git_config_set

2016-02-16 Thread Patrick Steinhardt
Rename git_config_set_or_die functions to git_config_set, leading to the new default behavior of dying whenever a configuration error occurs. By now all callers that shall die on error have been transitioned to the _or_die variants, thus making this patch a simple rename of the functions. Signed-