Re: [PATCH v5 1/7] add simple tests of consistency across rebase types

2013-06-04 Thread Martin von Zweigbergk
On Mon, Jun 3, 2013 at 11:15 PM, Johannes Sixt wrote: > Am 6/4/2013 7:14, schrieb Martin von Zweigbergk: >> On Mon, Jun 3, 2013 at 3:28 PM, Junio C Hamano wrote: + +# checks that the revisions in "$2" represent a linear range with the +# subjects in "$1" +test_linear_range ()

Re: [PATCH v5 1/7] add simple tests of consistency across rebase types

2013-06-03 Thread Johannes Sixt
Am 6/4/2013 7:14, schrieb Martin von Zweigbergk: > On Mon, Jun 3, 2013 at 3:28 PM, Junio C Hamano wrote: >>> + >>> +# checks that the revisions in "$2" represent a linear range with the >>> +# subjects in "$1" >>> +test_linear_range () { >>> + ! { git log --format=%p "$2" | sane_grep " " ;} &&

Re: [PATCH v5 1/7] add simple tests of consistency across rebase types

2013-06-03 Thread Junio C Hamano
Martin von Zweigbergk writes: > Thanks. Will wait another day or two for further comments before I > send another version. Thanks; I just noticed that your patches lack S-o-b:. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v5 1/7] add simple tests of consistency across rebase types

2013-06-03 Thread Martin von Zweigbergk
On Mon, Jun 3, 2013 at 3:28 PM, Junio C Hamano wrote: >> + >> +# checks that the revisions in "$2" represent a linear range with the >> +# subjects in "$1" >> +test_linear_range () { >> + ! { git log --format=%p "$2" | sane_grep " " ;} && > > An interesting way to spell: > > test $(git rev

Re: [PATCH v5 1/7] add simple tests of consistency across rebase types

2013-06-03 Thread Junio C Hamano
Martin von Zweigbergk writes: > Helped-by: Johannes Sixt > --- > t/lib-rebase.sh | 15 > t/t3421-rebase-topology-linear.sh | 78 > +++ > 2 files changed, 93 insertions(+) > create mode 100755 t/t3421-rebase-topology-linear.sh > >

[PATCH v5 1/7] add simple tests of consistency across rebase types

2013-06-03 Thread Martin von Zweigbergk
Helped-by: Johannes Sixt --- t/lib-rebase.sh | 15 t/t3421-rebase-topology-linear.sh | 78 +++ 2 files changed, 93 insertions(+) create mode 100755 t/t3421-rebase-topology-linear.sh diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh ind