Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
On Tue, May 26, 2015 at 4:53 PM, Eric Sunshine wrote: > On Tue, May 26, 2015 at 3:41 PM, Allen Hubbe wrote: >> On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine >> wrote: >>> On Saturday, May 23, 2015, Allen Hubbe wrote: + # recognize lines that look like an alias +

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 3:41 PM, Allen Hubbe wrote: > On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine > wrote: >> On Saturday, May 23, 2015, Allen Hubbe wrote: >>> diff --git a/git-send-email.perl b/git-send-email.perl >>> index e1e9b1460ced..ffea50094a48 100755 >>> --- a/git-send-email.perl >>>

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine wrote: > On Saturday, May 23, 2015, Allen Hubbe wrote: >> Note that this only adds support for a limited subset of the sendmail >> format. The format is is as follows. >> >> : [, ...] >> >> Aliases are specified one per line, and must start

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Eric Sunshine
On Saturday, May 23, 2015, Allen Hubbe wrote: > Note that this only adds support for a limited subset of the sendmail > format. The format is is as follows. > > : [, ...] > > Aliases are specified one per line, and must start on the first column of the > line. Blank lines are ignored. I

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Eric Sunshine
On Sat, May 23, 2015 at 1:45 PM, Junio C Hamano wrote: > Allen Hubbe writes: >> Note that this only adds support for a limited subset of the sendmail >> format. The format is is as follows. >> >> : [, ...] >> >> Aliases are specified one per line, and must start on the first column of the

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Junio C Hamano
Junio C Hamano writes: > It probably should be two patches. Your sendmail thing with docs > and tests as one patch (with $HOME in test), and fix to mailrc tests > I did (minus the part that fixes your sendmail test, which should > now become unnecessary) on top. > > If the documentation I queued

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Junio C Hamano
Allen Hubbe writes: >> Could you fetch from me and then run: >> >> $ git log --reverse -3 -p 6b733ee4ba330e1187017895b8426dd9171c33b8 >> >> to see if you agree with the result? That is what I queued on 'pu' >> for now with my fixups. > > It looks good to me. How would you like me to proceed?

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Allen Hubbe
On Mon, May 25, 2015 at 9:58 PM, Junio C Hamano wrote: > Allen Hubbe writes: > >> Thanks for letting me know. Are you still expecting v6 from me then? >> The other thing you asked for was a change in the documentation: just >> mention the email programs' documentation, and describe the >> except

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Junio C Hamano
Allen Hubbe writes: > Thanks for letting me know. Are you still expecting v6 from me then? > The other thing you asked for was a change in the documentation: just > mention the email programs' documentation, and describe the > exceptions. Could you fetch from me and then run: $ git log --reve

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Allen Hubbe
On Mon, May 25, 2015 at 5:35 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Junio C Hamano writes: >> >> FYI, I have tentatively queued this on top of your patch. Please >> see "git log master..cf954075" to double check. > > Sorry but I had a typo there... > >> git format-patch -

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Junio C Hamano
Junio C Hamano writes: > Junio C Hamano writes: > > FYI, I have tentatively queued this on top of your patch. Please > see "git log master..cf954075" to double check. Sorry but I had a typo there... > git format-patch -1 -o outdir && > - cat >>~/.tmp-email-aliases <<-\EOF && > +

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Junio C Hamano
Junio C Hamano writes: > Allen Hubbe writes: > >> Looking closer at this and the other test cases, they are inconsistent >> about using ".mailrc", "~/.mailrc", and "$(pwd)/.mailrc". This would >> add another one, "$HOME/.mailrc". > > In t9001, I see two tests on mailrc: > ... > So I do not see

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Junio C Hamano
Allen Hubbe writes: > Looking closer at this and the other test cases, they are inconsistent > about using ".mailrc", "~/.mailrc", and "$(pwd)/.mailrc". This would > add another one, "$HOME/.mailrc". In t9001, I see two tests on mailrc: * Create .mailrc in the current directory and point at i

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-25 Thread Allen Hubbe
On Sat, May 23, 2015 at 6:24 PM, Allen Hubbe wrote: > On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> A small thing I noticed in the test (and this patch is not adding a >>> new "breakage"---there are a few existing instances) is the use of >>> "~/"; it sh

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Allen Hubbe
On Sat, May 23, 2015 at 2:00 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> diff --git a/Documentation/git-send-email.txt >>> b/Documentation/git-send-email.txt >>> index 804554609def..97387fd27a8d 100644 >>> --- a/Documentation/git-send-email.txt >>> +++ b/Documentation/git-send-email

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Allen Hubbe
On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> A small thing I noticed in the test (and this patch is not adding a >> new "breakage"---there are a few existing instances) is the use of >> "~/"; it should be spelled "$HOME/" instead for portability (not in >>

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Junio C Hamano
Junio C Hamano writes: > A small thing I noticed in the test (and this patch is not adding a > new "breakage"---there are a few existing instances) is the use of > "~/"; it should be spelled "$HOME/" instead for portability (not in > POSIX, even though bash, dash and ksh all seem to understand it

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Junio C Hamano
Junio C Hamano writes: >> diff --git a/Documentation/git-send-email.txt >> b/Documentation/git-send-email.txt >> index 804554609def..97387fd27a8d 100644 >> --- a/Documentation/git-send-email.txt >> +++ b/Documentation/git-send-email.txt >> @@ -383,7 +383,42 @@ sendemail.aliasesFile:: >> >> se

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Junio C Hamano
Allen Hubbe writes: > Note that this only adds support for a limited subset of the sendmail > format. The format is is as follows. > > : [, ...] > > Aliases are specified one per line, and must start on the first column of the > line. Blank lines are ignored. If the first non whitespace

[PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-23 Thread Allen Hubbe
Note that this only adds support for a limited subset of the sendmail format. The format is is as follows. : [, ...] Aliases are specified one per line, and must start on the first column of the line. Blank lines are ignored. If the first non whitespace character on a line is a '#' sym