Re: [PATCH v5 07/35] hold_lock_file_for_append(): release lock on errors

2014-09-17 Thread Michael Haggerty
On 09/16/2014 10:48 PM, Jonathan Nieder wrote: > Michael Haggerty wrote: > >> --- a/lockfile.c >> +++ b/lockfile.c >> @@ -219,13 +219,13 @@ int hold_lock_file_for_append(struct lock_file *lk, >> const char *path, int flags) >> if (errno != ENOENT) { >> if (flags

Re: [PATCH v5 07/35] hold_lock_file_for_append(): release lock on errors

2014-09-16 Thread Jonathan Nieder
Michael Haggerty wrote: > --- a/lockfile.c > +++ b/lockfile.c > @@ -219,13 +219,13 @@ int hold_lock_file_for_append(struct lock_file *lk, > const char *path, int flags) > if (errno != ENOENT) { > if (flags & LOCK_DIE_ON_ERROR) > di

[PATCH v5 07/35] hold_lock_file_for_append(): release lock on errors

2014-09-16 Thread Michael Haggerty
If there is an error copying the old contents to the lockfile, roll back the lockfile before exiting so that the lockfile is not held until process cleanup. Signed-off-by: Michael Haggerty --- lockfile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lockfile.c b/lockfil