Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-30 Thread Karthik Nayak
On Wed, Jul 29, 2015 at 3:19 AM, Eric Sunshine wrote: > On Mon, Jul 27, 2015 at 3:27 AM, Karthik Nayak wrote: >> From: Karthik Nayak >> >> Since 'ref-filter' only has an option to match path names add an >> option for plain fnmatch pattern-matching. >> >> This is to support the pattern matching

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-29 Thread Karthik Nayak
On Wed, Jul 29, 2015 at 3:19 AM, Eric Sunshine wrote: > On Mon, Jul 27, 2015 at 3:27 AM, Karthik Nayak wrote: >> From: Karthik Nayak >> >> Since 'ref-filter' only has an option to match path names add an >> option for plain fnmatch pattern-matching. >> >> This is to support the pattern matching

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-28 Thread Eric Sunshine
On Mon, Jul 27, 2015 at 3:27 AM, Karthik Nayak wrote: > From: Karthik Nayak > > Since 'ref-filter' only has an option to match path names add an > option for plain fnmatch pattern-matching. > > This is to support the pattern matching options which are used in `git > tag -l` and `git branch -l` wh

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-27 Thread Karthik Nayak
On Mon, Jul 27, 2015 at 9:36 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> On Mon, Jul 27, 2015 at 9:27 PM, Karthik Nayak wrote: >>> On Mon, Jul 27, 2015 at 6:24 PM, Matthieu Moy >>> wrote: Karthik Nayak writes: > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -946,6

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-27 Thread Matthieu Moy
Karthik Nayak writes: > On Mon, Jul 27, 2015 at 9:27 PM, Karthik Nayak wrote: >> On Mon, Jul 27, 2015 at 6:24 PM, Matthieu Moy >> wrote: >>> Karthik Nayak writes: >>> --- a/ref-filter.c +++ b/ref-filter.c @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter,

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-27 Thread Karthik Nayak
On Mon, Jul 27, 2015 at 9:27 PM, Karthik Nayak wrote: > On Mon, Jul 27, 2015 at 6:24 PM, Matthieu Moy > wrote: >> Karthik Nayak writes: >> >>> --- a/ref-filter.c >>> +++ b/ref-filter.c >>> @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter, >>> struct commit *commit) >> >

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-27 Thread Karthik Nayak
On Mon, Jul 27, 2015 at 6:24 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> --- a/ref-filter.c >> +++ b/ref-filter.c >> @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter, >> struct commit *commit) > >> +/* >> + * Return 1 if the refname matches one of the patterns,

Re: [PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-27 Thread Matthieu Moy
Karthik Nayak writes: > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -946,6 +946,32 @@ static int commit_contains(struct ref_filter *filter, > struct commit *commit) > +/* > + * Return 1 if the refname matches one of the patterns, otherwise 0. > * A pattern can be path prefix (e.g. a refname

[PATCH v5 07/11] ref-filter: add option to match literal pattern

2015-07-27 Thread Karthik Nayak
From: Karthik Nayak Since 'ref-filter' only has an option to match path names add an option for plain fnmatch pattern-matching. This is to support the pattern matching options which are used in `git tag -l` and `git branch -l` where we can match patterns like `git tag -l foo*` which would match