Re: [PATCH v5 04/24] files-backend: convert git_path() to strbuf_git_path()

2017-03-02 Thread Duy Nguyen
On Wed, Mar 1, 2017 at 12:06 AM, Michael Haggerty wrote: >> @@ -2681,13 +2709,19 @@ static int files_rename_ref(struct ref_store >> *ref_store, >> log_all_ref_updates = flag; >> >> rollbacklog: >> - if (logmoved && rename(git_path("logs/%s", newrefname), >> git_path("logs/%s", oldref

Re: [PATCH v5 04/24] files-backend: convert git_path() to strbuf_git_path()

2017-02-28 Thread Michael Haggerty
On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote: > git_path() and friends are going to be killed in files-backend.c in near > future. And because there's a risk with overwriting buffer in > git_path(), let's convert them all to strbuf_git_path(). We'll have > easier time killing/converting strbu

[PATCH v5 04/24] files-backend: convert git_path() to strbuf_git_path()

2017-02-22 Thread Nguyễn Thái Ngọc Duy
git_path() and friends are going to be killed in files-backend.c in near future. And because there's a risk with overwriting buffer in git_path(), let's convert them all to strbuf_git_path(). We'll have easier time killing/converting strbuf_git_path() then because we won't have to worry about memor