Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-11-01 Thread Eric Sunshine
On Fri, Nov 1, 2013 at 12:35 PM, Junio C Hamano wrote: > Subject: [PATCH] transport-helper: demote lack of "force" option to a warning > > It would have been a good conservative position to take, if there > were no existing helpers, to die when the user asked to force a push > through a transport

Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-11-01 Thread Junio C Hamano
Felipe Contreras writes: > On Fri, Nov 1, 2013 at 8:49 AM, Junio C Hamano wrote: > >> Because updated helpers know 'force' option, such a s/die/warning/ >> change would not affect them at all. > > Yeah, that makes sense. OK, then let's queue this separately on top, so that we can revert it more

Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-11-01 Thread Felipe Contreras
On Fri, Nov 1, 2013 at 8:49 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Felipe Contreras writes: >> >>> On Thu, Oct 31, 2013 at 12:21 PM, Junio C Hamano wrote: Felipe Contreras writes: > Otherwise they cannot know when to force the push or not (other than > hacks)

Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-11-01 Thread Junio C Hamano
Junio C Hamano writes: > Felipe Contreras writes: > >> On Thu, Oct 31, 2013 at 12:21 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: >>> Otherwise they cannot know when to force the push or not (other than hacks). ... diff --git a/transport-helper.c b/transport-helpe

Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-10-31 Thread Junio C Hamano
Felipe Contreras writes: > On Thu, Oct 31, 2013 at 12:21 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> Otherwise they cannot know when to force the push or not (other than >>> hacks). >>> ... >>> diff --git a/transport-helper.c b/transport-helper.c >>> index d05fc7c..ed238e5 1006

Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-10-31 Thread Felipe Contreras
On Thu, Oct 31, 2013 at 12:21 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Otherwise they cannot know when to force the push or not (other than >> hacks). >> ... >> diff --git a/transport-helper.c b/transport-helper.c >> index d05fc7c..ed238e5 100644 >> --- a/transport-helper.c >> ++

Re: [PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-10-31 Thread Junio C Hamano
Felipe Contreras writes: > Otherwise they cannot know when to force the push or not (other than > hacks). > ... > diff --git a/transport-helper.c b/transport-helper.c > index d05fc7c..ed238e5 100644 > --- a/transport-helper.c > +++ b/transport-helper.c > @@ -854,6 +854,11 @@ static int push_refs_

[PATCH v5 03/10] transport-helper: add 'force' to 'export' helpers

2013-10-31 Thread Felipe Contreras
Otherwise they cannot know when to force the push or not (other than hacks). Tests-by: Richard Hansen Documentation-by: Richard Hansen Signed-off-by: Felipe Contreras --- Documentation/gitremote-helpers.txt | 4 git-remote-testgit.sh | 16 t/t5801-remote-he