Re: [PATCH v5 01/10] diff: export diffstat interface

2019-02-22 Thread Slavica Djukic
Hello Junio, Thank you for suggestions and for taking time to look at this patch series. On 21-Feb-19 6:53 PM, Junio C Hamano wrote: "Daniel Ferreira via GitGitGadget" writes: @@ -6001,12 +5985,7 @@ void diff_flush(struct diff_options *options) dirstat_by_line) {

Re: [PATCH v5 01/10] diff: export diffstat interface

2019-02-21 Thread Junio C Hamano
"Daniel Ferreira via GitGitGadget" writes: > @@ -6001,12 +5985,7 @@ void diff_flush(struct diff_options *options) > dirstat_by_line) { > struct diffstat_t diffstat; > > - memset(&diffstat, 0, sizeof(struct diffstat_t)); > - for (i = 0; i < q->nr;

[PATCH v5 01/10] diff: export diffstat interface

2019-02-20 Thread Daniel Ferreira via GitGitGadget
From: Daniel Ferreira Make the diffstat interface (namely, the diffstat_t struct and compute_diffstat) no longer be internal to diff.c and allow it to be used by other parts of git. This is helpful for code that may want to easily extract information from files using the diff machinery, while fl