Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Junio C Hamano
Matthieu Moy writes: > Which commit is this based on? > > "git am" fails, whether I try from Junio's master, next or pu. My best > try was from da608b124c76f8f7dba8a9d8f0bc8174b9744176. It seems you're > based on a local commit which doesn't exist on Junio's end. > > Most commit in-flight are in

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Eric Sunshine
On Wed, Jun 12, 2013 at 4:47 PM, Célestin Matte wrote: > Le 12/06/2013 22:34, Célestin Matte a écrit : >>> Célestin Matte writes: >> Actually, there still is a problem: the "defined(@array)" (introduced >> with the change in [21/31]) produces a warning. >> Benoit also seems to have problems with

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Célestin Matte
Le 12/06/2013 23:12, Matthieu Moy a écrit : > Which commit is this based on? > > "git am" fails, whether I try from Junio's master, next or pu. My best > try was from da608b124c76f8f7dba8a9d8f0bc8174b9744176. It seems you're > based on a local commit which doesn't exist on Junio's end. Indeed, we

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Matthieu Moy
Which commit is this based on? "git am" fails, whether I try from Junio's master, next or pu. My best try was from da608b124c76f8f7dba8a9d8f0bc8174b9744176. It seems you're based on a local commit which doesn't exist on Junio's end. Most commit in-flight are in next, so I guess rebasing the serie

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Célestin Matte
Le 12/06/2013 22:34, Célestin Matte a écrit : > Le 12/06/2013 22:02, Matthieu Moy a écrit : >> Célestin Matte writes: >> >>> Not many changes since v3. This version is only for fixing last typos and >>> applying Junio's recommandations for [21/31], which I forgot in v4. >>> At this point, the only

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Célestin Matte
Le 12/06/2013 22:02, Matthieu Moy a écrit : > Célestin Matte writes: > >> Not many changes since v3. This version is only for fixing last typos and >> applying Junio's recommandations for [21/31], which I forgot in v4. >> At this point, the only patch worth reviewing is [21/31]. > > Thanks. I we

Re: [PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Matthieu Moy
Célestin Matte writes: > Not many changes since v3. This version is only for fixing last typos and > applying Junio's recommandations for [21/31], which I forgot in v4. > At this point, the only patch worth reviewing is [21/31]. Thanks. I went through the series again and it all looks good. --

[PATCH v5 00/31] Follow perlcritic's recommandations

2013-06-12 Thread Célestin Matte
Not many changes since v3. This version is only for fixing last typos and applying Junio's recommandations for [21/31], which I forgot in v4. At this point, the only patch worth reviewing is [21/31]. Changes with v4 : - fixed typos - Change in [21/31]: all the processing is done within the subrou