Re: [PATCH v5 00/16] pathspec cleanup

2017-01-09 Thread Brandon Williams
On 01/07, Duy Nguyen wrote: > On Thu, Jan 5, 2017 at 1:03 AM, Brandon Williams wrote: > > Changes in v5: > > * Move GUARD_PATHSPEC to prevent checking if pathspec is null twice. > > * Mark a string containing 'mnemonic' for translation. > > Argh.. I've run out of things to complain about! Ack! h

Re: [PATCH v5 00/16] pathspec cleanup

2017-01-08 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Jan 5, 2017 at 1:03 AM, Brandon Williams wrote: >> Changes in v5: >> * Move GUARD_PATHSPEC to prevent checking if pathspec is null twice. >> * Mark a string containing 'mnemonic' for translation. > > Argh.. I've run out of things to complain about! Ack! Thanks ;-)

Re: [PATCH v5 00/16] pathspec cleanup

2017-01-07 Thread Duy Nguyen
On Thu, Jan 5, 2017 at 1:03 AM, Brandon Williams wrote: > Changes in v5: > * Move GUARD_PATHSPEC to prevent checking if pathspec is null twice. > * Mark a string containing 'mnemonic' for translation. Argh.. I've run out of things to complain about! Ack! -- Duy

[PATCH v5 00/16] pathspec cleanup

2017-01-04 Thread Brandon Williams
Changes in v5: * Move GUARD_PATHSPEC to prevent checking if pathspec is null twice. * Mark a string containing 'mnemonic' for translation. Brandon Williams (16): mv: remove use of deprecated 'get_pathspec()' dir: remove struct path_simplify dir: convert fill_directory to use the pathspec str