Re: [PATCH v5 00/11] Deprecate .git/info/grafts

2018-04-27 Thread Johannes Schindelin
Hi Junio, On Thu, 26 Apr 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > - if (export_object(&old_oid, type, raw, tmpfile)) > > - return -1; > > - if (launch_editor(tmpfile, NULL, NULL) < 0) > > - return error("editing object file failed"); > > - if (im

Re: [PATCH v5 00/11] Deprecate .git/info/grafts

2018-04-25 Thread Junio C Hamano
Johannes Schindelin writes: > -if (export_object(&old_oid, type, raw, tmpfile)) > -return -1; > -if (launch_editor(tmpfile, NULL, NULL) < 0) > -return error("editing object file failed"); > -if (import_object(&new_oid, type, raw, tmpfile)) > +tmpfile

[PATCH v5 00/11] Deprecate .git/info/grafts

2018-04-25 Thread Johannes Schindelin
It is fragile, as there is no way for the revision machinery to say "but now I want to traverse the graph ignoring the graft file" e.g. when pushing commits to a remote repository (which, as a consequence, can miss commits). And we already have a better solution with `git replace --graft [...]`.