Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-11 Thread Johannes Sixt
Am 11.09.19 um 19:48 schrieb Pratyush Yadav: > Since this entire debate essentially boils down to personal preference, > there is no clear answer. So I'll just go with the author's > implementation. Fair enough. -- Hannes

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-11 Thread Pratyush Yadav
On 11/09/19 08:49AM, Birger Skogeng Pedersen wrote: > Hi Pratyush, > > On Tue, Sep 10, 2019 at 9:12 PM Pratyush Yadav wrote: > > This patch LGTM, but I'm not sure how to resolve the keybindings > > problem. Junio suggested we have configurable keybindings, and I agree > > with him, but until we d

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-10 Thread Birger Skogeng Pedersen
Hi Pratyush, On Tue, Sep 10, 2019 at 9:12 PM Pratyush Yadav wrote: > This patch LGTM, but I'm not sure how to resolve the keybindings > problem. Junio suggested we have configurable keybindings, and I agree > with him, but until we do, something has to be agreed upon. And we also > need to come u

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-10 Thread Pratyush Yadav
+Cc j6t This patch LGTM, but I'm not sure how to resolve the keybindings problem. Junio suggested we have configurable keybindings, and I agree with him, but until we do, something has to be agreed upon. And we also need to come up with a reasonable default. So, I don't have any preferences fo

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-05 Thread Pratyush Yadav
On 04/09/19 04:38PM, Junio C Hamano wrote: > Pratyush Yadav writes: > > > On 04/09/19 11:39PM, Johannes Sixt wrote: > >> Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen: > >> > On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote: > >> >> Many keyboards do not have a right Alt-key. That means

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Junio C Hamano
Pratyush Yadav writes: > On 04/09/19 11:39PM, Johannes Sixt wrote: >> Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen: >> > On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote: >> >> Many keyboards do not have a right Alt-key. That means that Alt+1 to >> >> Alt+4 combinations must be typed s

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Pratyush Yadav
On 04/09/19 11:39PM, Johannes Sixt wrote: > Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen: > > On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote: > >> Many keyboards do not have a right Alt-key. That means that Alt+1 to > >> Alt+4 combinations must be typed single-handed with the left hand

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Johannes Sixt
Am 04.09.19 um 21:55 schrieb Bert Wesarg: > I use my left thumb to press the left Alt key and it does not feel > mildly awkward. As Alt is also used for the mnemonics, there will > probably more of mildly awkward key combinations, wont there? That may well be the case. However, it is the commit me

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Johannes Sixt
Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen: > On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote: >> Many keyboards do not have a right Alt-key. That means that Alt+1 to >> Alt+4 combinations must be typed single-handed with the left hand. This >> is mildly awkward for Alt+4. Can we plea

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Bert Wesarg
Dear Hannes, On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote: > > Am 04.09.19 um 16:30 schrieb Birger Skogeng Pedersen: > > The user cannot change focus between the list of files, the diff view and > > the commit message widgets without using the mouse (clicking either of > > the four widgets)

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Birger Skogeng Pedersen
Hi Johannes, On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote: > Many keyboards do not have a right Alt-key. That means that Alt+1 to > Alt+4 combinations must be typed single-handed with the left hand. This > is mildly awkward for Alt+4. Can we please have the very important > commit widget *n

Re: [PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Johannes Sixt
Am 04.09.19 um 16:30 schrieb Birger Skogeng Pedersen: > The user cannot change focus between the list of files, the diff view and > the commit message widgets without using the mouse (clicking either of > the four widgets). > > With this patch, the user may set ui focus to the previously selected

[PATCH v5] git-gui: Add hotkeys to set widget focus

2019-09-04 Thread Birger Skogeng Pedersen
The user cannot change focus between the list of files, the diff view and the commit message widgets without using the mouse (clicking either of the four widgets). With this patch, the user may set ui focus to the previously selected path in either the "Unstaged Changes" or "Staged Changes" widget