Re: [PATCH v4 7/7] tests: order arguments to git-rev-list properly

2018-10-05 Thread Junio C Hamano
Matthew DeVore writes: > I screwed up by putting the positional argument *after* the > redirection. Sorry for the mix-up. This is interestingly syntactically > valid, though bad stylistically. Here is an inter-diff: Thanks for being careful. Except for a rather idiomatic echo >&2 mess

Re: [PATCH v4 7/7] tests: order arguments to git-rev-list properly

2018-10-03 Thread Matthew DeVore
On Wed, Oct 3, 2018 at 9:26 AM Matthew DeVore wrote: > > - git -C pc1 rev-list HEAD --quiet --objects --missing=print >revs && > + git -C pc1 rev-list --quiet --objects --missing=print >revs HEAD && > awk -f print_1.awk revs | ... > git -C pc1 blame origin/master -- fil

[PATCH v4 7/7] tests: order arguments to git-rev-list properly

2018-10-03 Thread Matthew DeVore
It is a common mistake to put positional arguments before flags when invoking git-rev-list. Order the positional arguments last. This patch skips git-rev-list invocations which include the --not flag, since the ordering of flags and positional arguments affects the behavior. This patch also skips