Re: [PATCH v4 5/6] rebase -i: support --ignore-date

2019-10-06 Thread Rohit Ashiwal
On Fri, 27 Sep 2019 11:00:58 +0100 Phillip Wood wrote: > > [...] Thanks for all the advice and improvements. > [...] > It's good to see the new test. Did you see Stolee's email [4] about the > test coverage of the previous version of this series? You should check > that this series tests all th

Re: [PATCH v4 5/6] rebase -i: support --ignore-date

2019-09-27 Thread Phillip Wood
Hi Rohit This is an improvement but there are a couple of outstanding issues from the previous round with regard to handing --ignore-date when GIT_COMMITTER_DATE is set. I'll try and look at the rest of the series soon. On 07/09/2019 12:50, Rohit Ashiwal wrote: rebase am already has this fla

Re: [PATCH v4 5/6] rebase -i: support --ignore-date

2019-09-07 Thread Rohit Ashiwal
On Sat, 7 Sep 2019 17:20:33 +0530 Rohit Ashiwal wrote: > [...] > +test_expect_success '--ignore-date works with rebase -r' ' > + git checkout side && > + git merge commit3 && Should use --no-ff option to be sure that it handles "merge" commits properly. Same for [3/6]. Please Junio chan

[PATCH v4 5/6] rebase -i: support --ignore-date

2019-09-07 Thread Rohit Ashiwal
rebase am already has this flag to "lie" about the author date by changing it to the committer (current) date. Let's add the same for interactive machinery. Signed-off-by: Rohit Ashiwal --- Documentation/git-rebase.txt| 6 +-- builtin/rebase.c| 18 ++---